Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does AppTx name not get used for any kind of registration? #112

Closed
rigelrozanski opened this issue Jun 16, 2017 · 1 comment
Closed

Does AppTx name not get used for any kind of registration? #112

rigelrozanski opened this issue Jun 16, 2017 · 1 comment

Comments

@rigelrozanski
Copy link
Contributor

https://github.com/tendermint/basecoin/blob/master/types/tx.go#L198
I'm wondering if the name field is used for anything besides printing response information back to the CLI. if this is the case maybe we can figure out a way to eliminate it, or label its function more clearly. I was under the impression that app txs need to be registered in some capacity and this name would invoke looking up a certain command or registered transaction.

@ethanfrey
Copy link
Contributor

Yeah, when an apptx comes in, the executor looks for a registered plugin with that name. Then passes the data to that plugin.

So, you need to register the plugin with a name and the apptx better have the same name as the plugin

liamsi pushed a commit to liamsi/cosmos-sdk that referenced this issue Jun 26, 2018
make PubKeyEd25519.Address() returns the first 20 bytes of the hash of the raw 32-byte pubkey, no amino required
rootulp referenced this issue in rootulp/cosmos-sdk Oct 21, 2022
* adds orchestrator address to validator initialization in staking module

* fix msg edit  validator

* todo

* todo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants