orm/model/ormdb: (moduleDB).DefaultJSON writes table JSON non-deterministically due to map iteration

[odeke-em]

Summary of Bug

If we audit the code in

cosmos-sdk/orm/model/ormdb/json.go

Lines 18 to 33 in 686c50d

	for name, table := range m.tablesByName {
	w, err := target.OpenWriter(name)
	if err != nil {
	return err
	}
	_, err = w.Write(table.DefaultJSON())
	if err != nil {
	return err
	}
	err = w.Close()
	if err != nil {
	return err
	}
	}

we can see that the various tables' JSON is written to dependent only on the map's iteration order

Version

77cf430

Fix

diff --git a/orm/model/ormdb/json.go b/orm/model/ormdb/json.go
index 3a64ae52f..79a668ccd 100644
--- a/orm/model/ormdb/json.go
+++ b/orm/model/ormdb/json.go
@@ -15,7 +15,17 @@ import (
 )
 
 func (m moduleDB) DefaultJSON(target ormjson.WriteTarget) error {
-	for name, table := range m.tablesByName {
+	tableNames := make([]protoreflect.FullName, 0, len(m.tablesByName))
+	for name := range m.tablesByName {
+		tableNames = append(tableNames, name)
+	}
+	sort.Slice(tableNames, func(i, j int) bool {
+		ti, tj := tableNames[i], tableNames[j]
+		return ti.Name() < tj.Name()
+	})
+
+	for _, name := range tableNames {
+		table := m.tablesByName[name]
 		w, err := target.OpenWriter(name)
 		if err != nil {
 			return err

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied