Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate upgrade module to use mocks #12500

Closed
2 tasks
Tracked by #12398
tac0turtle opened this issue Jul 9, 2022 · 0 comments · Fixed by #12698
Closed
2 tasks
Tracked by #12398

migrate upgrade module to use mocks #12500

tac0turtle opened this issue Jul 9, 2022 · 0 comments · Fixed by #12698
Assignees

Comments

@tac0turtle
Copy link
Member

tac0turtle commented Jul 9, 2022

  • write mocks
  • migrate keeper tests from integration based testing to use mocks
@tac0turtle tac0turtle changed the title x/upgrade migrate upgrade module to use mocks Jul 9, 2022
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK Jul 9, 2022
@likhita-809 likhita-809 self-assigned this Jul 25, 2022
@likhita-809 likhita-809 moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Jul 25, 2022
@likhita-809 likhita-809 moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Jul 25, 2022
@mergify mergify bot closed this as completed in #12698 Jul 27, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Jul 27, 2022
mergify bot pushed a commit that referenced this issue Jul 27, 2022
## Description

Closes: #12500 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants