Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Staking spec updates #1268

Closed
1 task
ebuchman opened this issue Jun 15, 2018 · 6 comments · Fixed by #3281
Closed
1 task

Staking spec updates #1268

ebuchman opened this issue Jun 15, 2018 · 6 comments · Fixed by #3281
Assignees
@rigelrozanski
Labels
C:x/staking spec

Comments

@ebuchman
Copy link
Member

ebuchman commented Jun 15, 2018 •
edited by jackzampolin
Loading

Following up on #1263, we discussed some other updates:

  • Change the naming:
    • Unbonded -> PotentialBonded
    • LooseUnbonded -> NotBonded
  • Remove SlashRatio
  • Notes about decisions made for efficiency sake (eg. the GlobalPool)

We also discussed removing PoolShares, but we can leave them for now with exchange rate of 1.

We also need to clearly document how we use notation and what things like -> and | mean

Related Issues:
@cwgoes
Copy link
Contributor

cwgoes commented Jun 15, 2018

Do we have a "spec spec" somewhere? Ideally we could use common notation across Tendermint / SDK / ABCI specification documents.

@ebuchman ebuchman added the spec label Jun 19, 2018
@ebuchman
Copy link
Member Author

WE NEED A SPEC SPEC !

@ebuchman ebuchman mentioned this issue Jun 19, 2018
Open
@jackzampolin
Copy link
Member

Is this being worked on by anyone?

@jackzampolin jackzampolin mentioned this issue Dec 8, 2018
Closed
@jackzampolin
Copy link
Member

@rigelrozanski Any update here?

@cwgoes
Copy link
Contributor

cwgoes commented Jan 10, 2019 •
edited
Loading

The staking spec could use a reunification with the code.

I plan to work on this after F1 (perhaps in conjunction with @rigelrozanski if he is so inclined!).

@rigelrozanski
Copy link
Contributor

@cwgoes working on this now, I'm restructuring the spec so it doesn't have pseudo code but only accurately and concisely describes the objectives of the code - the pseudo-code is moreless useless and a hassle to maintain

@rigelrozanski rigelrozanski mentioned this issue Jan 11, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rigelrozanski rigelrozanski

Labels
C:x/staking spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R4R: Staking Spec Upgrade cosmos/cosmos-sdk
5 participants
@ebuchman @alexanderbez @jackzampolin @rigelrozanski @cwgoes