Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Staking Spec Upgrade #3281

Merged
merged 78 commits into from
Jan 22, 2019
Merged

R4R: Staking Spec Upgrade #3281

merged 78 commits into from
Jan 22, 2019

Conversation

rigelrozanski
Copy link
Contributor

@rigelrozanski rigelrozanski commented Jan 11, 2019

  • general minor reorg of spec folder
  • switch staking spec to remove pseudo code and only accurately and concisely describes the objectives of the code
  • other minor things:
    • some missing json struct tags for MsgCreateValidator where updated
    • missing ensure length was added to handleMsgCreateValidator

closes #1268

followup issues:
#3324
#3325
#3326

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments ☝️ I think we need some more explaination in a couple of the sections noted. Also maybe we should break the LooseTokens -> NotBondedTokens stuff out to another PR?

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass. I think this spec is definitely more useful than the current pseudocode, but I would also like to see a more abstract "staking model" spec outlining the formal properties we're trying to provide (e.g., lying to a lite client is always a slashable offense). That doesn't need to happen in this PR.

docs/spec/SPEC-SPEC.md Outdated Show resolved Hide resolved
docs/spec/SPEC-SPEC.md Outdated Show resolved Hide resolved
docs/spec/SPEC-SPEC.md Outdated Show resolved Hide resolved
docs/spec/reserve-pool/TODO.md Show resolved Hide resolved
docs/spec/SPEC-SPEC.md Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
docs/spec/vesting/TODO.md Outdated Show resolved Hide resolved
@rigelrozanski rigelrozanski changed the base branch from rigel/delegation-index to develop January 16, 2019 10:35
@rigelrozanski rigelrozanski added T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). and removed non-breaking labels Jan 19, 2019
x/staking/types/pool.go Outdated Show resolved Hide resolved
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor suggestions - once addressed/applied LGTM.

docs/spec/staking/TODO.md Show resolved Hide resolved
docs/spec/reserve-pool/TODO.md Outdated Show resolved Hide resolved
docs/spec/staking/end_block.md Outdated Show resolved Hide resolved
docs/spec/staking/end_block.md Outdated Show resolved Hide resolved
docs/spec/staking/end_block.md Outdated Show resolved Hide resolved
docs/spec/staking/end_block.md Outdated Show resolved Hide resolved
docs/spec/staking/end_block.md Outdated Show resolved Hide resolved
docs/spec/staking/end_block.md Outdated Show resolved Hide resolved
docs/spec/staking/state.md Outdated Show resolved Hide resolved
@rigelrozanski rigelrozanski merged commit 7f789d2 into develop Jan 22, 2019
@rigelrozanski rigelrozanski deleted the rigel/stakin-spec-upgrade branch January 22, 2019 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/staking T: API Breaking Breaking changes that impact APIs and the SDK only (not state machine). T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Staking spec updates
4 participants