-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: Staking Spec Upgrade #3281
Conversation
…dex' into rigel/delegation-index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments ☝️ I think we need some more explaination in a couple of the sections noted. Also maybe we should break the LooseTokens
-> NotBondedTokens
stuff out to another PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass. I think this spec is definitely more useful than the current pseudocode, but I would also like to see a more abstract "staking model" spec outlining the formal properties we're trying to provide (e.g., lying to a lite client is always a slashable offense). That doesn't need to happen in this PR.
Co-Authored-By: rigelrozanski <rigel.rozanski@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor suggestions - once addressed/applied LGTM.
closes #1268
followup issues:
#3324
#3325
#3326
Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
Wrote tests
Updated relevant documentation (
docs/
)Added entries in
PENDING.md
with issue #rereviewed
Files changed
in the github PR explorerFor Admin Use: