Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite x/group tests to use mocks #12763

Closed
Tracked by #12398
tac0turtle opened this issue Jul 28, 2022 · 0 comments · Fixed by #12864
Closed
Tracked by #12398

rewrite x/group tests to use mocks #12763

tac0turtle opened this issue Jul 28, 2022 · 0 comments · Fixed by #12864
Assignees
@atheeshp
Labels
T: Tests

Comments

@tac0turtle
Copy link
Member

No description provided.

@tac0turtle tac0turtle mentioned this issue Jul 28, 2022
Closed
27 tasks
@tac0turtle tac0turtle moved this to 📝 Todo in Cosmos-SDK Jul 28, 2022
@atheeshp atheeshp self-assigned this Jul 28, 2022
@atheeshp atheeshp mentioned this issue Aug 9, 2022
Merged
19 tasks
@amaury1093 amaury1093 moved this from 📝 Todo to 💪 In Progress in Cosmos-SDK Aug 10, 2022
@atheeshp atheeshp changed the title rewrite x/groups tests to use mocks rewrite x/group tests to use mocks Aug 11, 2022
@atheeshp atheeshp moved this from 💪 In Progress to 👀 Needs Review in Cosmos-SDK Aug 17, 2022
@mergify mergify bot closed this as completed in #12864 Aug 22, 2022
Repository owner moved this from 👀 Needs Review to 👏 Done in Cosmos-SDK Aug 22, 2022
mergify bot pushed a commit that referenced this issue Aug 22, 2022
@atheeshp
feat: x/group tests to mocks (#12864)
9412bcd 
## Description

Closes: #12763 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@tac0turtle tac0turtle removed this from Cosmos-SDK Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atheeshp atheeshp

Labels
T: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: x/group tests to mocks cosmos/cosmos-sdk
2 participants
@tac0turtle @atheeshp