Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sdk.Router #12803

Closed
2 tasks
tac0turtle opened this issue Aug 3, 2022 · 3 comments · Fixed by #13005
Closed
2 tasks

Remove sdk.Router #12803

tac0turtle opened this issue Aug 3, 2022 · 3 comments · Fixed by #13005
Assignees
@facundomedica
Labels
S:blocked Status: Blocked Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@tac0turtle
Copy link
Member

Summary

Recently legacy querier and other items were removed from the app module interface. As part of this, all the sdk.Router can be removed as well.

Todo:
@tac0turtle tac0turtle changed the title Remove sdk.Router & rewrite baseapp tests Remove sdk.Router Aug 3, 2022
@tac0turtle tac0turtle added Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. S:blocked Status: Blocked labels Aug 3, 2022
@facundomedica
Copy link
Member

Is this still blocked? I would like to give it a go. This means we need to change the router and the hardcoded messages with proto generated messages and replace sdk.Router usages with MsgServiceRouter right?

@tac0turtle
Copy link
Member Author

yes, its still blocked on rewriting base app tests. You could dive into both if you'd like

@facundomedica
Copy link
Member

Ok, I'll look into it 💪

@facundomedica facundomedica mentioned this issue Aug 29, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@facundomedica facundomedica

Labels
S:blocked Status: Blocked Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: Remove sdk.Router and refactor baseapp tests cosmos/cosmos-sdk
2 participants
@facundomedica @tac0turtle