refactor!: Remove sdk.Router and refactor baseapp tests #13005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13005 +/- ##
==========================================
- Coverage 55.87% 53.43% -2.45%
==========================================
Files 646 647 +1
Lines 54895 55083 +188
==========================================
- Hits 30675 29434 -1241
- Misses 21762 23307 +1545
+ Partials 2458 2342 -116
|
…-sdk into facu/remove-router
github-actions
bot
added
C:CLI
C:Simulations
C:Store
C:x/bank
C:x/distribution
alexanderbez
approved these changes
Aug 30, 2022
tac0turtle
approved these changes
Aug 30, 2022
In terms of coverage, this PR increases it by 0.1%; so no difference. I basically took most tests and converted them, only leaving out what was testing the router specifically. |
amaury1093
reviewed
Aug 31, 2022
| @@ -367,17 +364,6 @@ func (app *BaseApp) setIndexEvents(ie []string) { | |||
| } | |||
| } | |||
|
|
|||
| // Router returns the legacy router of the BaseApp. | |||
| func (app *BaseApp) Router() sdk.Router { | |||
There was a problem hiding this comment.
We probably should have added an API-breaking changelog for this baseapp removal
| @@ -149,7 +147,6 @@ func NewBaseApp( | |||
| db: db, | |||
| cms: store.NewCommitMultiStore(db), | |||
| storeLoader: DefaultStoreLoader, | |||
| router: NewRouter(), | |||
| queryRouter: NewQueryRouter(), | |||
There was a problem hiding this comment.
Looking at this, the legacy query router can also be removed, since #12725. @facundomedica would you like to take care of this too?
Wryhder
pushed a commit
to Wryhder/cosmos-sdk
that referenced
this pull request
Oct 26, 2022
* test * progress-ish * progress * progress * make mocks * progress * test * progress * progress * progress * progress * progress * progress * fix mock tests * progress * pretty much done, might need some tidying up * lint * re-enable blockgas test * remove router * gofumpt * remove more references of Router * fix * remove unused code * remove unused code Co-authored-by: Marko <marbar3778@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #12802
Closes: #12803
Note to reviewers: I had to split some tests between
baseappandbaseapp_testbecause of 1. cyclic deps, 2. needed access to unexported fields.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change