Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy appmodule boiler plate #12725

Merged
merged 14 commits into from
Jul 28, 2022
Merged

Conversation

tac0turtle
Copy link
Member

@tac0turtle tac0turtle commented Jul 26, 2022

Description

Closes: #11863, #11552

  • Remove legacy queriers
  • Remove interface legacy functions

cc @alexanderbez @ValarDragon

@tac0turtle tac0turtle marked this pull request as ready for review July 26, 2022 16:43
@tac0turtle tac0turtle requested a review from a team as a code owner July 26, 2022 16:43
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a changelog entry for this for sure!

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Show resolved Hide resolved
UPGRADING.md Outdated Show resolved Hide resolved
tac0turtle and others added 3 commits July 28, 2022 12:41
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
@tac0turtle tac0turtle merged commit 3a09701 into main Jul 28, 2022
@tac0turtle tac0turtle deleted the marko/11863-remove-legacy branch July 28, 2022 11:18
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
* remove legacy appmodule boiler plate

* remove legacy code

* remove legacy gov rest routes

* remove staking querier

* fix legacy

* remove unused test

* add upgrading and changelog entry

* Update UPGRADING.md

Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* fix tests

Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move module.go methods deprecated by RegisterServices into an extension interface
3 participants