Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign-batch is setting wrong sequences for txs. #13199

Closed
atheeshp opened this issue Sep 8, 2022 · 0 comments · Fixed by #13200
Closed

sign-batch is setting wrong sequences for txs. #13199

atheeshp opened this issue Sep 8, 2022 · 0 comments · Fixed by #13200
Assignees

Comments

@atheeshp
Copy link
Contributor

atheeshp commented Sep 8, 2022

Summary of Bug

sign-batch is always setting sequences from 0 though the from account has previously committed few txns.

$ ./simd tx bank send test cosmos1y0kuvghxh8dc24sx9pmn3rah7vw42hdje664vx 10stake --generate-only --home test/ --keyring-backend test >> unsigned.json

$ ./simd tx sign-batch unsigned_tx.json --home test/ --keyring-backend test --from test --signature-only=false
{"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1ecljq450dtpwaa3hxpyd3564s0x86pejc7vmd9","to_address":"cosmos1y0kuvghxh8dc24sx9pmn3rah7vw42hdje664vx","amount":[{"denom":"stake","amount":"10"}]}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AnoeNXKRVbHttgeQr50LNEOFWlbL7DlBGsxNC7OysWb2"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["8vV3/NlIcasbfkB+WDtrt2IDagzuUi+5vpcB1sBMwBE9gt4Ve3X+kbBSaVZv5KySxwgMWZpzgnxFm8qi9LhswQ=="]}

sign-batch with multiple txs

./simd tx sign-batch unsigned_tx.json --home test/ --keyring-backend test --from test --signature-only=false 
{"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1ecljq450dtpwaa3hxpyd3564s0x86pejc7vmd9","to_address":"cosmos1y0kuvghxh8dc24sx9pmn3rah7vw42hdje664vx","amount":[{"denom":"stake","amount":"10"}]}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AnoeNXKRVbHttgeQr50LNEOFWlbL7DlBGsxNC7OysWb2"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"0"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["8vV3/NlIcasbfkB+WDtrt2IDagzuUi+5vpcB1sBMwBE9gt4Ve3X+kbBSaVZv5KySxwgMWZpzgnxFm8qi9LhswQ=="]}
{"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1ecljq450dtpwaa3hxpyd3564s0x86pejc7vmd9","to_address":"cosmos1y0kuvghxh8dc24sx9pmn3rah7vw42hdje664vx","amount":[{"denom":"stake","amount":"10"}]}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AnoeNXKRVbHttgeQr50LNEOFWlbL7DlBGsxNC7OysWb2"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"1"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["+sQs0Ph18GJvKlmekMIZpqtnLUeClkPaeh68U3WP1Bd1A2afcZNXR3w49pOEExim7cwZxVDqpb+v2HijJH/Zeg=="]}

sign is setting correct sequence here.

$ ./simd tx sign unsigned_tx.json --home test/ --keyring-backend test --from test
{"body":{"messages":[{"@type":"/cosmos.bank.v1beta1.MsgSend","from_address":"cosmos1ecljq450dtpwaa3hxpyd3564s0x86pejc7vmd9","to_address":"cosmos1y0kuvghxh8dc24sx9pmn3rah7vw42hdje664vx","amount":[{"denom":"stake","amount":"10"}]}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]},"auth_info":{"signer_infos":[{"public_key":{"@type":"/cosmos.crypto.secp256k1.PubKey","key":"AnoeNXKRVbHttgeQr50LNEOFWlbL7DlBGsxNC7OysWb2"},"mode_info":{"single":{"mode":"SIGN_MODE_DIRECT"}},"sequence":"3"}],"fee":{"amount":[],"gas_limit":"200000","payer":"","granter":""},"tip":null},"signatures":["G64JXVDn0dpeqTCX4Ru4UYw265CMEbOKbOnqO7o+Rl92EyaYSEU0cwiVOZ1f9EVsG36EaaAvl/K8O8egMNKZrw=="]}

Version

0.46, main

Steps to Reproduce

  • choose a from account which has previously executed txns on chain.
  • generate one or more txns with --generate-only mode with the selected from account & combine them into one file
  • sign the tx using sign-batch and observe the sequences in the signed tx.
@atheeshp atheeshp self-assigned this Sep 8, 2022
@mergify mergify bot closed this as completed in 04858ea Sep 13, 2022
mergify bot pushed a commit that referenced this issue Sep 13, 2022
## Description

Closes: #13199

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 04858ea)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant