Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests requiring ledger support should be skipped by default #16035

Closed
aaronc opened this issue May 4, 2023 · 1 comment · Fixed by #16078
Closed

Tests requiring ledger support should be skipped by default #16035

aaronc opened this issue May 4, 2023 · 1 comment · Fixed by #16078
Assignees
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code) T: Tests

Comments

@aaronc
Copy link
Member

aaronc commented May 4, 2023

Tests requiring ledger support always run when using go test ./... or my IDE and always fail because ledger support isn't enabled by default.

We should either filter these out with the existing ledger build tag or use some flag to skip them.

Here's a list of such tests:
image

@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label May 4, 2023
@aaronc aaronc added T: Tests T: Dev UX UX for SDK developers (i.e. how to call our code) labels May 4, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK May 4, 2023
@julienrbrt
Copy link
Member

It seems like it was done purposely (?):

return nil, errors.New("support for ledger devices is not available in this executable")

@julienrbrt julienrbrt removed the needs-triage Issue that needs to be triaged label May 4, 2023
@tac0turtle tac0turtle self-assigned this May 10, 2023
@github-project-automation github-project-automation bot moved this from 📝 Todo to 👏 Done in Cosmos-SDK May 10, 2023
@tac0turtle tac0turtle removed this from Cosmos-SDK Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code) T: Tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants