Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run ledger tests when flags are set #16078

Merged
merged 4 commits into from
May 10, 2023
Merged

chore: run ledger tests when flags are set #16078

merged 4 commits into from
May 10, 2023

Conversation

tac0turtle
Copy link
Member

Description

Closes: #16035

add build flags to ledger test files, we had them set elsewhere just not in the file that housed the tests


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle marked this pull request as ready for review May 10, 2023 09:44
@tac0turtle tac0turtle requested a review from a team as a code owner May 10, 2023 09:44
@github-prbot github-prbot requested review from a team, aaronc and alexanderbez and removed request for a team May 10, 2023 09:47
@tac0turtle tac0turtle enabled auto-merge May 10, 2023 11:15
@tac0turtle tac0turtle added this pull request to the merge queue May 10, 2023
Merged via the queue into main with commit 6fd417e May 10, 2023
@tac0turtle tac0turtle deleted the marko/16035 branch May 10, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests requiring ledger support should be skipped by default
2 participants