-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove cosmossdk.io/x/* dependence in the root go module #18290
Comments
Perhaps we should think about spinning out the Go module for "cosmossdk.io/testutil" because in the root go.mod, the reason why we need a bunch of those modules added to the top level is because testutil/network uses them, it doesn't have a go.mod file and can't use a replace directive and guess what? Almost every module imports "github.com/cosmos/cosmos-sdk/testuti/*" per this command $ git grep 'github.com/cosmos/cosmos-sdk/testutil' | cut -d":" -f1 | xargs dirname | sort | uniq and that currently returns unique 148 directories that import it |
i dont think we should move the entire thing but parts of it, we will handle this issue |
i think testutils is the only worry here. since baseapp client and server will be deleted this year |
closing this in favour of #20279 |
While spinning out modules from the cosmos sdk go.mod we introduced module imports into the cosmos sdk. We need to remove these.
The text was updated successfully, but these errors were encountered: