Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detected dangling dependency on deprecated tendermint/tmlibs #2388

Closed
4 tasks
alessio opened this issue Sep 24, 2018 · 0 comments
Closed
4 tasks

Detected dangling dependency on deprecated tendermint/tmlibs #2388

alessio opened this issue Sep 24, 2018 · 0 comments
Assignees
@alessio
Labels
good first issue T:Bug

Comments

@alessio
Copy link
Contributor

alessio commented Sep 24, 2018

Summary of Bug

https://github.com/cosmos/cosmos-sdk/blob/develop/client/keys/show.go#L12 still depends on the tendermint/tmlibs repo, which is dead and should be replaced by tendermint/tendermint

Steps to Reproduce

[ -d vendor/github.com/tendermint/tmlibs ] && echo yes || echo no

Reported by @greg-szabo on Slack

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alessio alessio

Labels
good first issue T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alessio