Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly init proposer for LCD tests #2416

Closed
rigelrozanski opened this issue Sep 28, 2018 · 1 comment · Fixed by #2429
Closed

Properly init proposer for LCD tests #2416

rigelrozanski opened this issue Sep 28, 2018 · 1 comment · Fixed by #2429
Assignees
@alexanderbez
Labels
C:x/distribution distribution module related

Comments

@rigelrozanski
Copy link
Contributor

An annoying problem I'm experiencing is properly initializing the proposer node for the lcd tests - becomes relevant for distribution - currently just uninitialized - new validators are initialized for the test, whereas the actual node who is running is not initialized - this generates problems for distribution end-block functionality as the proposer needs to have a ValidatorInfo object to receive proposer rewards

Blocks #2236
@rigelrozanski rigelrozanski added lcd C:x/distribution distribution module related labels Sep 28, 2018
@rigelrozanski
Copy link
Contributor Author

rigelrozanski commented Oct 2, 2018 •
edited
Loading

cosmos-sdk/client/lcd/test_helpers.go

Line 127 in 6cbac79

privVal := pvm.LoadOrGenFilePV(privValidatorFile)

is where the proposer validator is generated (but not currently added to the genesis val set in staking )

Basically need to make sure that privVal info is included in genDoc.Validators

@alexanderbez alexanderbez mentioned this issue Oct 2, 2018
Merged
5 tasks
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@sainoe
remove logger in app.go (cosmos#2416)
7032202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:x/distribution distribution module related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

R4R: LCD: Properly Init Proposing Validator in Tests cosmos/cosmos-sdk
2 participants
@alexanderbez @rigelrozanski