Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee as type Coins instead of Coin #25

Closed
rigelrozanski opened this issue Feb 10, 2017 · 1 comment
Closed

Fee as type Coins instead of Coin #25

rigelrozanski opened this issue Feb 10, 2017 · 1 comment

Comments

@rigelrozanski
Copy link
Contributor

Why should the fee only be one coin, maybe there are multiple types of coins that could be sent as a fee? If the transaction is already provisioning the type of coin the validator is going to need to be making complex value judgements between currencies, so why not?

@rigelrozanski
Copy link
Contributor Author

rigelrozanski commented Feb 10, 2017

Additionally, this will allow us to send true fee-less transactions because the type coin is always initialized with something, aka var fee types.coin has the default value of {"",0} built in, which creates problems if you don't want to send in coins of the type "" with your transaction.

  • The other option is to modify the validity checks to ignore a coin type if the amount is zero

sahith-narahari pushed a commit that referenced this issue Feb 22, 2021
Raumo0 pushed a commit to mapofzones/cosmos-sdk that referenced this issue Feb 13, 2022
sosedoff referenced this issue in figment-networks/cosmos-sdk May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant