Using gaiacli config node breaks ~/.gaiacli/config/config.toml

[mperklin]

Summary of Bug

When the user uses the gaiacli config node command to set the node value, the new value is written successfully to the ~/.gaiacli/config/config.toml file, however a new line is created with characters from the previously-set node value.
In short, using the gaiacli config node <newvalue> command will break your config.toml file.

This seems to only occur when the new node value has 2-or-more fewer characters than the old/original node value.

Steps to Reproduce

1. Install cosmos-sdk and ensure gaiacli is working as expected
2. Set an initial node value that is somewhat long by issuing the command: gaiacli config node my_local_host:26657. Note that this new value is 19 characters long.
3. Confirm the value exists in the config.toml file by issuing the command: cat ~/.gaiacli/config/config.toml. You should see the following output in your terminal:

node = "my_local_host:26657"

4. Set a new node value that is shorter than the value you set in step 2 by issuing the command: gaiacli config node localhost:26657. Note that this new value is 15 characters long, 4 characters shorter than the value in step test in tests/tendermint/main.go fails #2 above
5. Confirm the value written to the config.toml file by issuing the command: cat ~/.gaiacli/config/config.toml. You should see the following output in your terminal:

node = "localhost:26657"
57"

Note that three characters (57") are now present on the next line in the config file.
6. Attempt to perform any action with gaiacli. For example, execute the command gaiacli status
7. Observe the following error message:

ERROR: While parsing config: (3, 1): unexpected token

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[okwme]

just ran into this too

[mperklin]

Upon further playing, I now believe the value is blindly overwritten by the gaiad config node command.

If the value is the same length or greater, the overwrite works as expected.
However, if the value is shorter in length, the \n character from the new value overwrites the old value, leaving the remaining characters from the old value present in the file.

In my example above with a 19-char value overwritten by a 15-char value, 4 characters remain.
However the first character is overwritten by the new value's \n, leaving three characters visible "on the next line"

[alexanderbez]

Wow great catch guys! We should fix this asap -- doesn't look terribly difficult.