Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear duplication of code in x/auth/client/cli/decode.go #5424

Closed
4 tasks
alessio opened this issue Dec 18, 2019 · 1 comment · Fixed by #5427
Closed
4 tasks

Clear duplication of code in x/auth/client/cli/decode.go #5424

alessio opened this issue Dec 18, 2019 · 1 comment · Fixed by #5427
Labels
C:CLI good first issue

Comments

@alessio
Copy link
Contributor

alessio commented Dec 18, 2019

x/auth/client/cli.GetDecodeCommand() and x/auth/client/cli.GetDecodeTxCmd() should be collapsed into one command as there's a clear duplication of code, names and functionalities.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
alessio pushed a commit that referenced this issue Dec 18, 2019
Remove code duplication in x/auth/client/cli
1dec0ec 
Commands decode-tx and decode were performing the same function.
The command decode-tx is now dropped and replaced by decode.

Closes: #5424
@alessio alessio mentioned this issue Dec 18, 2019
Merged
11 tasks
@girishramnani
Copy link

@alessio is this issue being actively worked on? if not I would like to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:CLI good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove code duplication in x/auth/client/cli cosmos/cosmos-sdk
2 participants
@alessio @girishramnani