Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types/module package depends on x/simulation #5724

Closed
4 tasks
alessio opened this issue Feb 28, 2020 · 0 comments · Fixed by #5835
Closed
4 tasks

types/module package depends on x/simulation #5724

alessio opened this issue Feb 28, 2020 · 0 comments · Fixed by #5835
Assignees
@jgimeno
Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@alessio
Copy link
Contributor

alessio commented Feb 28, 2020

SDK top-level packages and types should not depend on x/ packages.

Currently github.com/cosmos/cosmos-sdk/types/module/simulation.go imports github.com/cosmos/cosmos-sdk/x/simulation.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@alessio alessio added core Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. labels Feb 28, 2020
@jgimeno jgimeno self-assigned this Mar 19, 2020
@jgimeno jgimeno mentioned this issue Mar 19, 2020
Merged
11 tasks
alessio pushed a commit that referenced this issue Mar 23, 2020
@jgimeno
Remove dependency of types/module package on x/simulation (#5835)
49102b1 
Closes: #5724
@alessio alessio mentioned this issue Sep 15, 2020
Merged
9 tasks
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this issue May 22, 2023
@jgimeno
Remove dependency of types/module package on x/simulation (cosmos#5835)
658cd7e 
Closes: cosmos#5724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgimeno jgimeno

Labels
Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency of types/module package on x/simulation cosmos/cosmos-sdk
2 participants
@alessio @jgimeno