Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default genesis state missing for ibc module #6082

Closed
4 tasks
sahith-narahari opened this issue Apr 27, 2020 · 6 comments · Fixed by #6139
Closed
4 tasks

Default genesis state missing for ibc module #6082

sahith-narahari opened this issue Apr 27, 2020 · 6 comments · Fixed by #6139

Comments

@sahith-narahari
Copy link
Contributor

Summary of Bug

The current implementation of ibc module has nil for default genesis state but validates the genesis with unmarshal. This prevents creating a valid genesis state in current master

The exact source of issue can be found here

func (AppModuleBasic) DefaultGenesis(_ codec.JSONMarshaler) json.RawMessage {

This is currently a blocker for cli_tests #6033

Version

hash - 97e1c31

Steps to Reproduce


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@jackzampolin jackzampolin added this to the IBC 1.0 milestone Apr 27, 2020
@fedekunze
Copy link
Collaborator

duplicate of #5948

@anilcse anilcse mentioned this issue May 4, 2020
11 tasks
@aaronc
Copy link
Member

aaronc commented May 4, 2020

@fedekunze @jackzampolin is there not supposed to be a DefaultGenesis for IBC?

@fedekunze
Copy link
Collaborator

There is, we need to export clients, channels, connections, sequences, etc. It's already on master 👍

@aaronc
Copy link
Member

aaronc commented May 4, 2020

Should we reopen this then?

@fedekunze
Copy link
Collaborator

Should we reopen this then?

GenesisState for IBC was already implemented. It's on master

@aaronc
Copy link
Member

aaronc commented May 4, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants