Add setup for cli_test #6033

sahith-narahari · 2020-04-20T18:43:41Z

ref: #5951

Description

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

…-cli-test

…-cli-tests

…s-sdk into sahith/add-cli-test

…-base-setup

aaronc

This looks like a good start. Can you add a github actions CI task to run test-cli @sahith-narahari ? I think we need to modify test-cover.sh so that these tests don't run there and so that they run in a separate CI task.

…-base-setup

sahith-narahari · 2020-04-20T21:29:06Z

thanks @aaronc , added test-cli to circleci

aaronc · 2020-04-20T21:33:44Z

thanks @aaronc , added test-cli to circleci

@sahith-narahari, sorry not circleci, github actions please. My understanding is that we're trying to migrate all CI there.

aaronc · 2020-04-27T20:42:49Z

IMHO cli_test/helpers functions and types should live inside our top-level tests package. That's where we've placed all testing-related auxiliary functions and types so far. I would even avoid creating a tests/cli subdir - dropping everything in cli_helpers.go would possibly just do it.

I am in favor of moving cli_test -> tests/cli so that all test stuff lives under tests. I would caution against putting everything in a cli_helpers.go file. I think the reorganization that @sahith-narahari is helpful and we shouldn't move back to a single large file with everything.

So I would say let's create two package there - tests/cli/helpers and tests/cli/tests instead of a new cli_test root package.

Are you okay with that @alessio ?

alessio · 2020-04-27T21:00:27Z

sounds good to me @aaronc

tests/cli/helpers/utils.go

aaronc · 2020-04-28T16:44:46Z

What is the plan to get this to completion? Will each module be done in a separate PR (this is what I recommend)?

Yes the plan is to address this module by module. I believe some of that work has already started.

alexanderbez · 2020-04-28T17:12:10Z

Great! What is left remaining for this PR to be wrapped up?

…os-sdk into sahith/add-base-setup

codecov · 2020-04-28T17:54:23Z

Codecov Report

Merging #6033 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6033   +/-   ##
=======================================
  Coverage   54.78%   54.78%           
=======================================
  Files         437      437           
  Lines       26433    26433           
=======================================
  Hits        14482    14482           
  Misses      10955    10955           
  Partials      996      996

aaronc · 2020-04-28T18:49:25Z

Great! What is left remaining for this PR to be wrapped up?

Looks like just some fixes to CI. Once that's fixed LGTM

aaronc

LGTM 🎉

anilcse · 2020-04-28T23:01:40Z

x/ibc/module.go


-	return gs.Validate()
+	// TODO: UNDO this when DefaultGenesis() is implemented


As @anilcse has noted here, there is an issue with IBC ValidateGenesis that was breaking cli tests. I suggest we merge this PR with ValidateGenesis commented out like this so that cli tests can proceed. When the IBC team fixes this issue, they can uncomment these lines.

@anilcse Is there a currently open issue / PR for tracking this and making sure this doesn't get forgotten? #5948 seems to be closed, and I cant find any open related issues.

Threre's none. May be we can reopen this issue: #6082

there is an issue with IBC ValidateGenesis that was breaking cli tests.

which one?

DefaultGenesis is not implemented and it just returns nil

DefaultGenesis is defined in x/ibc/genesis.go

alexanderbez

ACK

Changed requested addressed and/or planned to be in subsequent PRs.

sahith-narahari added 17 commits April 15, 2020 03:57

Added cli integration base setup

014caf8

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…

a42c097

…-cli-test

Added cmd to simapp

df53367

Fixed ci-lint issues

c2e22b9

Fixed ci-lint issues

13b5531

Addressed changes in Makefile

858e744

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…

0755f09

…-cli-tests

Updated simd to latest

0ae1966

Removed testnet and replay commands

6f362fd

Modified tx command for simcli

5136a91

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…

295b023

…-cli-tests

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…

df2424a

…-cli-tests

Did code cleanup

da5b8e3

Merge branch 'sahith/add-cli-tests' of github.com:regen-network/cosmo…

6e82b44

…s-sdk into sahith/add-cli-test

Removed duplication in Makefile

0ef94f2

Refactored cli_test

6670f90

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…

e130c40

…-base-setup

sahith-narahari changed the title ~~Sahith/add base setup~~ Add setup for cli_test Apr 20, 2020

Added build-sim to Makefile

bc88c76

aaronc requested changes Apr 20, 2020

View reviewed changes

sahith-narahari added 2 commits April 21, 2020 02:47

Added test-cli to circleci

baa4b60

Merge branch 'master' of github.com:cosmos/cosmos-sdk into sahith/add…

828092c

…-base-setup

sahith-narahari marked this pull request as ready for review April 20, 2020 21:29

sahith-narahari requested review from alessio, alexanderbez, fedekunze, hschoenburg and nylira as code owners April 20, 2020 21:29

Added build flag to cli_tests

6e90919

Moved cli_test to tests

5fc398c

alexanderbez reviewed Apr 28, 2020

View reviewed changes

tests/cli/helpers/utils.go Outdated Show resolved Hide resolved

Merge branch 'master' into sahith/add-base-setup

f351b47

sahith-narahari added 3 commits April 28, 2020 22:47

Modified path in Makefile

e400f11

Merge branch 'sahith/add-base-setup' of github.com:regen-network/cosm…

53e8e9c

…os-sdk into sahith/add-base-setup

Updated codec std in fixtures

e3913ae

sahith-narahari and others added 2 commits April 29, 2020 02:13

Added doc for cli tests

8454ecc

Remove ibc genesis validation

0b167c6

aaronc approved these changes Apr 28, 2020

View reviewed changes

anilcse reviewed Apr 28, 2020

View reviewed changes

Fix issue number

55b8d0d

alexanderbez approved these changes Apr 29, 2020

View reviewed changes

Merge branch 'master' into sahith/add-base-setup

5e2446b

alessio approved these changes Apr 29, 2020

View reviewed changes

alexanderbez requested a review from fedekunze April 29, 2020 14:01

aaronc added 2 commits April 29, 2020 10:33

Merge branch 'master' into sahith/add-base-setup

56fcb11

Merge branch 'master' into sahith/add-base-setup

22d58ee

alexanderbez merged commit 3b71198 into cosmos:master Apr 29, 2020

clevinson added this to the v0.39 milestone May 4, 2020

sahith-narahari deleted the sahith/add-base-setup branch May 15, 2020 12:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add setup for cli_test #6033

Add setup for cli_test #6033

sahith-narahari commented Apr 20, 2020 •

edited by alexanderbez

Loading

aaronc left a comment •

edited

Loading

sahith-narahari commented Apr 20, 2020 •

edited

Loading

aaronc commented Apr 20, 2020

aaronc commented Apr 27, 2020

alessio commented Apr 27, 2020

aaronc commented Apr 28, 2020

alexanderbez commented Apr 28, 2020

codecov bot commented Apr 28, 2020 •

edited

Loading

aaronc commented Apr 28, 2020

aaronc left a comment

anilcse Apr 28, 2020

aaronc Apr 29, 2020 •

edited

Loading

alexanderbez Apr 29, 2020

clevinson May 4, 2020 •

edited

Loading

anilcse May 4, 2020

fedekunze May 4, 2020

fedekunze May 4, 2020

alexanderbez left a comment


		return gs.Validate()
		// TODO: UNDO this when DefaultGenesis() is implemented

Add setup for cli_test #6033

Add setup for cli_test #6033

Conversation

sahith-narahari commented Apr 20, 2020 • edited by alexanderbez Loading

Description

aaronc left a comment • edited Loading

Choose a reason for hiding this comment

sahith-narahari commented Apr 20, 2020 • edited Loading

aaronc commented Apr 20, 2020

aaronc commented Apr 27, 2020

alessio commented Apr 27, 2020

aaronc commented Apr 28, 2020

alexanderbez commented Apr 28, 2020

codecov bot commented Apr 28, 2020 • edited Loading

Codecov Report

aaronc commented Apr 28, 2020

aaronc left a comment

Choose a reason for hiding this comment

anilcse Apr 28, 2020

Choose a reason for hiding this comment

aaronc Apr 29, 2020 • edited Loading

Choose a reason for hiding this comment

alexanderbez Apr 29, 2020

Choose a reason for hiding this comment

clevinson May 4, 2020 • edited Loading

Choose a reason for hiding this comment

anilcse May 4, 2020

Choose a reason for hiding this comment

fedekunze May 4, 2020

Choose a reason for hiding this comment

fedekunze May 4, 2020

Choose a reason for hiding this comment

alexanderbez left a comment

Choose a reason for hiding this comment

sahith-narahari commented Apr 20, 2020 •

edited by alexanderbez

Loading

aaronc left a comment •

edited

Loading

sahith-narahari commented Apr 20, 2020 •

edited

Loading

codecov bot commented Apr 28, 2020 •

edited

Loading

aaronc Apr 29, 2020 •

edited

Loading

clevinson May 4, 2020 •

edited

Loading