Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/keys: --algo flag silently falls back to default if user supplied algo is not supported #6402

Closed
4 tasks done
alessio opened this issue Jun 11, 2020 · 0 comments · Fixed by #6405
Closed
4 tasks done
Assignees
Labels
C:Keys Keybase, KMS and HSMs T:Bug

Comments

@alessio
Copy link
Contributor

alessio commented Jun 11, 2020

	algo, err := keyring.NewSigningAlgoFromString(viper.GetString(flagKeyAlgo))
	if err != nil {
		algo = hd.Secp256k1
	}

Proposed solution, as discussed with @fedekunze, is to add a function to Keyring interface through which the caller can retrieve the list of algos supported by the keyring itself.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Keys Keybase, KMS and HSMs T:Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants