Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: fix signing algorithm #6405

Merged
merged 11 commits into from
Jun 11, 2020
Merged

client: fix signing algorithm #6405

merged 11 commits into from
Jun 11, 2020

Conversation

fedekunze
Copy link
Collaborator

Description

closes: #6402


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@fedekunze fedekunze added T:Bug WIP C:Keys Keybase, KMS and HSMs labels Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #6405 into master will increase coverage by 0.00%.
The diff coverage is 85.71%.

@@           Coverage Diff           @@
##           master    #6405   +/-   ##
=======================================
  Coverage   55.54%   55.54%           
=======================================
  Files         465      465           
  Lines       27515    27524    +9     
=======================================
+ Hits        15284    15289    +5     
- Misses      11133    11136    +3     
- Partials     1098     1099    +1     

@fedekunze fedekunze changed the title crypto/keyring: fix signing algorithm client: fix signing algorithm Jun 11, 2020
@fedekunze fedekunze marked this pull request as ready for review June 11, 2020 14:12
@fedekunze fedekunze added R4R and removed WIP labels Jun 11, 2020
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

crypto/keyring/keyring.go Outdated Show resolved Hide resolved
crypto/keyring/keyring.go Outdated Show resolved Hide resolved
Alessio Treglia and others added 2 commits June 11, 2020 16:20
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
Copy link
Contributor

@alessio alessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small suggestions - though this is good to go already

@fedekunze fedekunze added the A:automerge Automatically merge PR once all prerequisites pass. label Jun 11, 2020
@mergify mergify bot merged commit 0215b5c into master Jun 11, 2020
@mergify mergify bot deleted the fedekunze/6402-fix-keyring-algo branch June 11, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Keys Keybase, KMS and HSMs T:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

client/keys: --algo flag silently falls back to default if user supplied algo is not supported
3 participants