-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: fix signing algorithm #6405
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6405 +/- ##
=======================================
Coverage 55.54% 55.54%
=======================================
Files 465 465
Lines 27515 27524 +9
=======================================
+ Hits 15284 15289 +5
- Misses 11133 11136 +3
- Partials 1098 1099 +1 |
fedekunze
changed the title
crypto/keyring: fix signing algorithm
client: fix signing algorithm
Jun 11, 2020
fedekunze
requested review from
aaronc,
alessio,
clevinson and
jgimeno
as code owners
June 11, 2020 14:12
alexanderbez
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
alessio
reviewed
Jun 11, 2020
alessio
reviewed
Jun 11, 2020
alessio
reviewed
Jun 11, 2020
alessio
reviewed
Jun 11, 2020
alessio
reviewed
Jun 11, 2020
alessio
reviewed
Jun 11, 2020
Co-authored-by: Alessio Treglia <alessio@tendermint.com>
alessio
approved these changes
Jun 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left small suggestions - though this is good to go already
fedekunze
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #6402
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorer