Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor channel fixes #7949

Closed
3 of 9 tasks
colin-axner opened this issue Nov 16, 2020 · 0 comments · Fixed by #8665
Closed
3 of 9 tasks

minor channel fixes #7949

colin-axner opened this issue Nov 16, 2020 · 0 comments · Fixed by #8665
Labels
good first issue
Milestone
IBC 1.0.1 [non-br...

Comments

@colin-axner
Copy link
Contributor

colin-axner commented Nov 16, 2020 •
edited by fedekunze
Loading

Summary

  • Call connectionEnd.GetVersions() once in channel handshakes
  • condense codec.go registrations (registerimplementation will register interfaces)
  • put acknowledgement result/error into its own file
  • basic validation of a channel should check that the state is not UNINITIALIZED. Currently it checks that the string is not empty
  • rename var counterPartyHops to counterpartyHops in channel handshake

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@colin-axner colin-axner changed the title channel handshake should call get versions once minor channel fixes Nov 16, 2020
@colin-axner colin-axner mentioned this issue Nov 17, 2020
Merged
9 tasks
Merged
9 tasks
@damiannolan damiannolan mentioned this issue Feb 22, 2021
Merged
9 tasks
colin-axner added a commit that referenced this issue Mar 1, 2021
@damiannolan @colin-axner
minor channel fixes (#8665)
0792db7 
* Consolidating codec.go registrations. Moving Acknowledgement result/error to its own file

* Updating CHANGELOG.md with #7949 improvement as requested

* revert removing acknowledgement proto to its own file

* update changelog

* remove unnecessary pb.go file

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
IBC 1.0.1 [non-breaking post-Stargate...
Development

Successfully merging a pull request may close this issue.

minor channel fixes
1 participant
@colin-axner