Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coins IsValid() Ordering #8

Closed
rigelrozanski opened this issue Jan 23, 2017 · 1 comment
Closed

Coins IsValid() Ordering #8

rigelrozanski opened this issue Jan 23, 2017 · 1 comment
Labels
T:Bug

Comments

@rigelrozanski
Copy link
Contributor

It appears as though the IsValid() method is only checking if each coin is sorted against the first coin denom, not the previous denom in order? https://github.com/tendermint/basecoin/blob/master/types/coin.go#L30-L34
@ethanfrey
Copy link
Contributor

You are very right. Fixed in develop, commit 2f7875d

ethanfrey added a commit that referenced this issue Jan 31, 2017
@ethanfrey
Fixed Coins IsValid, issue #8
2f7875d
cwgoes pushed a commit that referenced this issue Oct 9, 2018
Merge pull request #8 from cosmos/cwgoes/patch-fix
d46b562 
Minor cleanup
dogemos added a commit to dogemos/cosmos-sdk that referenced this issue Apr 9, 2020
@dogemos
Merge pull request cosmos#8 from cosmos/develop
19cd8e9 
Sync fork
ulbqb pushed a commit to ulbqb/cosmos-sdk that referenced this issue Jun 8, 2023
@Manav-Aggarwal
feat: Move tracing to IAVL tree substore for Fraud Proof implementati…
ef454f0 
…on (cosmos#8)

* New IAVL Design (cosmos#7)

* WIP: New IAVL design

* Fix typos and update docs

* Remove cosmos-sdk tracer usage

* Verify first existence proof

* Modify abci methods to accomodate new design

* refactor abci

* Baseapp test works now

* Remove usage of SetTracerFor

* Remove leftover code

* Update go mod file

* Run gofumpt

* Refactor and add docs

* Set length of witness
luchenqun pushed a commit to luchenqun/cosmos-sdk that referenced this issue Sep 29, 2023
@mergify @GAtom22 @fedekunze
imp(cli): add 'auto' option for fees flag (backport cosmos#8) (cosmos#10
796a9d7 
)

Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: tom <tomasguerraalda@hotmail.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this issue Mar 1, 2024
@alexanderbez
Merge PR cosmos#8: Add Github Templates
cd40d54
DongLieu pushed a commit to Genuine-labs/cosmos-sdk that referenced this issue Mar 29, 2024
@nghuyenthevinh2000
feat: additions for Terra Classic (cosmos#8)
c4e15be 
* Add prioritized oracle message
* Add delegation limit
* Make interblock cache configurable
ezreal1997 added a commit to ezreal1997/cosmos-sdk that referenced this issue Oct 19, 2024
@ezreal1997
feat(x/distribution): refactor ubi funcs (cosmos#8)
5fb24e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethanfrey @rigelrozanski