Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate code for x/auth/ante.signatureDataToBz #9753

Closed
4 tasks
amaury1093 opened this issue Jul 22, 2021 · 0 comments
Closed
4 tasks

Remove duplicate code for x/auth/ante.signatureDataToBz #9753

amaury1093 opened this issue Jul 22, 2021 · 0 comments
Assignees
@amaury1093
Labels
C:x/auth Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.

Comments

@amaury1093
Copy link
Contributor

Summary

Small clean-up issue to remove duplicated code introduced to not break API. ref: #9750 (comment)

Problem Definition

We decided in #9750 (comment) to:

  • keep some duplicate code that will be backported, so that we don't introduce APi-breaking changes on backports,
  • update master with API breakages so that code is non-duplicated

Proposal

Detailed in #9750 (comment)

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added the Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity. label Jul 22, 2021
@amaury1093 amaury1093 self-assigned this Jul 22, 2021
@amaury1093 amaury1093 mentioned this issue Jul 22, 2021
Merged
19 tasks
@github-actions github-actions bot added the stale label Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amaury1093 amaury1093

Labels
C:x/auth Type: Code Hygiene General cleanup and restructuring of code to provide clarity, flexibility, and modularity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amaury1093