feat: Query txs by signature and by address+seq #9750

amaury1093 · 2021-07-22T10:30:22Z

Description

Closes: #9741

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed the correct type prefix in the PR title
confirmed ! in the type prefix if API or client breaking change
confirmed all author checklist items have been addressed
reviewed state machine logic
reviewed API design and naming
reviewed documentation is accurate
reviewed tests and test coverage
manually tested (if applicable)

orijbot · 2021-07-22T10:30:26Z

Visit https://dashboard.github.orijtech.com?pr=9750&repo=cosmos%2Fcosmos-sdk to see benchmark details.

x/auth/client/cli/query.go

baseapp/baseapp.go

x/auth/ante/sigverify.go

codecov · 2021-07-22T13:33:09Z

Codecov Report

Merging #9750 (1eb8abd) into master (f4d0682) will decrease coverage by 0.17%.
The diff coverage is 58.15%.

❗ Current head 1eb8abd differs from pull request most recent head 78b7526. Consider uploading reports for the commit 78b7526 to get more accurate results

@@            Coverage Diff             @@
##           master    #9750      +/-   ##
==========================================
- Coverage   63.47%   63.30%   -0.18%     
==========================================
  Files         566      563       -3     
  Lines       52797    52947     +150     
==========================================
+ Hits        33515    33518       +3     
- Misses      17379    17520     +141     
- Partials     1903     1909       +6

Impacted Files	Coverage Δ
types/events.go	`82.77% <ø> (ø)`
x/auth/client/cli/query.go	`0.00% <0.00%> (ø)`
x/auth/ante/sigverify.go	`68.07% <38.00%> (-5.86%)`	⬇️
x/auth/client/testutil/suite.go	`96.31% <100.00%> (+0.40%)`	⬆️
types/dec_coin.go	`77.27% <0.00%> (-21.93%)`	⬇️
x/bank/keeper/send.go	`84.02% <0.00%> (-1.62%)`	⬇️
x/auth/tx/decoder.go	`79.66% <0.00%> (-0.18%)`	⬇️
x/bank/keeper/view.go	`88.33% <0.00%> (-0.10%)`	⬇️
x/staking/client/testutil/suite.go	`99.42% <0.00%> (-0.01%)`	⬇️
x/bank/migrations/v044/store.go
... and 9 more

CHANGELOG.md

aaronc

I think this mostly covers it. Thanks @AmauryM. Left two comments - one about nested signatures in multisigs and the other as to whether we want to concat address+sequence.

x/auth/ante/sigverify.go

types/events.go

x/auth/ante/sigverify.go

… into am/9741-tx-query

odeke-em · 2021-07-26T15:05:36Z

Nice work @AmauryM, and I've approved your follow up PR, thank you!

robert-zaremba

Looks good. Left few cosmetic comments.

robert-zaremba · 2021-07-27T11:24:33Z

types/events.go

+	EventTypeTx = "tx"
+
+	AttributeKeyAccountSequence = "acc_seq"
+	AttributeKeySignature       = "signature"


Why not adding it under other AttributeKey*?

These attributes are for tx.*, the attributes below are for message.*

x/auth/ante/sigverify.go

x/auth/client/cli/query.go

robert-zaremba · 2021-07-27T11:45:14Z

x/auth/client/testutil/suite.go

+	// Query the tx by hash to get the inner tx.
+	out, err = clitestutil.ExecTestCLICmd(val.ClientCtx, authcli.QueryTxCmd(), []string{txRes.TxHash, fmt.Sprintf("--%s=json", tmcli.OutputFlag)})
+	s.Require().NoError(err)
+	s.Require().NoError(val.ClientCtx.Codec.UnmarshalJSON(out.Bytes(), &txRes))


the lines above a repeated in this file, can we move it to another function and reuse it?
Eg:

recipient, txRes, err := sendCoins(val, "newAccount2", 10) // maybe we can add coins to the return

A function for sending coins already exists (createBankMsg()). I think putting the ExecTestCLICmd for authcli.QueryTxCmd() separately is okay.

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

## Description Closes: #9741  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 7c19434) # Conflicts: # CHANGELOG.md # x/auth/client/cli/query.go

## Description Closes: #9741  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 7c19434) # Conflicts: # CHANGELOG.md # x/auth/client/cli/cli_test.go # x/auth/client/cli/query.go

* feat: Query txs by signature and by address+seq (#9750)  ## Description Closes: #9741  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 7c19434) # Conflicts: # CHANGELOG.md # x/auth/client/cli/query.go * Fix conflicts * Fix cl * Fix conflicts Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

* feat: Query txs by signature and by address+seq (#9750)  ## Description Closes: #9741  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 7c19434) # Conflicts: # CHANGELOG.md # x/auth/client/cli/cli_test.go # x/auth/client/cli/query.go * Fix conflicts * Fix build * Fix IBC test * use createBankMsg from master Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

cosmos#9782) * feat: Query txs by signature and by address+seq (cosmos#9750)  ## Description Closes: cosmos#9741  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 7c19434) # Conflicts: # CHANGELOG.md # x/auth/client/cli/query.go * Fix conflicts * Fix cl * Fix conflicts Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

@jleni

* docs: add v0.43 release version option (backport cosmos#9506) (cosmos#9677) * docs: add v0.43 version option (cosmos#9506) Co-authored-by: ryanchrypto <12519942+ryanchrypto@users.noreply.github.com> (cherry picked from commit 325dabd) # Conflicts: # docs/versions * fix conflicts Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * chore: Add missing entry in 0.42.7 Changelog (cosmos#9722) * fix: support output flag on tx commands (backport cosmos#9717) (cosmos#9772) * fix: support output flag on tx commands (cosmos#9717)  ## Description Closes: cosmos#9684  * feat: Query txs by signature and by address+seq (backport cosmos#9750) (cosmos#9783) * feat: Query txs by signature and by address+seq (cosmos#9750)  ## Description Closes: cosmos#9741  * fix: hardcoded ledger algo on `keys add` (backport cosmos#9766) (cosmos#9804) * fix: hardcoded ledger algo on `keys add` (cosmos#9766)  ## Description Closes: cosmos#9734 cc: @jleni  * chore: Add Changelog and Release Notes for v0.42.8 (cosmos#9807) * chore: Add Changelog and Release Notes for v0.42.8 * Change date * feat: Improve withdraw-all-rewards UX (backport cosmos#9781) (cosmos#9825) * feat: Improve withdraw-all-rewards UX (cosmos#9781) ## Description Related to cosmos#9489, this PR improves the UX when using the `withdraw-all-rewards` command by forcing the broadcast mode to `block` if the chunk size is greater than 0. This will ensure that the transactions do not fail even if the user uses invalid broadcast modes for this command (`sync` and `async`). * fix: Capability Issue on Restart, Backport to v0.42 (cosmos#9835) * implement BeginBlock fix * add changelog * fix lint * address reviews * Update CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> * address reviews * Apply suggestions from code review Co-authored-by: Robert Zaremba <robert@zaremba.ch> * move store check * add api breaking changelog * fix lint Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> * Fixed the --recover flag not working properly inside the init command (cosmos#9201) (cosmos#9850) Co-authored-by: Alessio Treglia <alessio@tendermint.com> (cherry picked from commit fdbc32e) Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> * chore: prepare 0.42.9 release (cosmos#9852) * prepare 0.42.9 release * add 9201 to changelog Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> Co-authored-by: Aditya <adityasripal@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Robert Zaremba <robert@zaremba.ch> Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>

cosmos#9782) * feat: Query txs by signature and by address+seq (cosmos#9750)  Closes: cosmos#9741  --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 7c19434) * Fix conflicts * Fix cl * Fix conflicts Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

cosmos#9783) * feat: Query txs by signature and by address+seq (cosmos#9750)  ## Description Closes: cosmos#9741  --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) (cherry picked from commit 7c19434) # Conflicts: # CHANGELOG.md # x/auth/client/cli/cli_test.go # x/auth/client/cli/query.go * Fix conflicts * Fix build * Fix IBC test * use createBankMsg from master Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>

amaury1093 added 3 commits July 21, 2021 15:06

WIP for auth query

dafbe1f

Make query by addr and seq work

d801fbd

Add tests for sigs

3628100

Merge branch 'master' into am/9741-tx-query

51f4cf2

github-actions bot added C:CLI C:x/auth labels Jul 22, 2021

Make query by sig work

ea3dc2e

amaury1093 commented Jul 22, 2021

View reviewed changes

x/auth/client/cli/query.go Outdated Show resolved Hide resolved

baseapp/baseapp.go Outdated Show resolved Hide resolved

amaury1093 added 2 commits July 22, 2021 13:51

Fix lint

96d357c

Improve err message

069e823

amaury1093 marked this pull request as ready for review July 22, 2021 11:58

amaury1093 requested review from aaronc and alexanderbez as code owners July 22, 2021 11:58

amaury1093 added 3 commits July 22, 2021 14:27

Move HasExtensionOptionsTx to authtx?

f319d4a

Switch to bez's CLI UX

eb06533

Fix cycle dep

b7218b1

amaury1093 commented Jul 22, 2021

View reviewed changes

x/auth/ante/sigverify.go Outdated Show resolved Hide resolved

alexanderbez approved these changes Jul 22, 2021

View reviewed changes

x/auth/ante/sigverify.go Outdated Show resolved Hide resolved

amaury1093 added backport/0.42.x (Stargate) labels Jul 22, 2021

amaury1093 mentioned this pull request Jul 22, 2021

Remove duplicate code for x/auth/ante.signatureDataToBz #9753

Closed

4 tasks

Cleanups

56c331a

amaury1093 commented Jul 22, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

620b3ea

alexanderbez approved these changes Jul 22, 2021

View reviewed changes

aaronc reviewed Jul 22, 2021

View reviewed changes

x/auth/ante/sigverify.go Outdated Show resolved Hide resolved

types/events.go Outdated Show resolved Hide resolved

x/auth/ante/sigverify.go Outdated Show resolved Hide resolved

amaury1093 added 2 commits July 23, 2021 09:42

Emit all nested sigs

76f6fdd

Merge branch 'am/9741-tx-query' of ssh://github.com/cosmos/cosmos-sdk…

acefab9

… into am/9741-tx-query

amaury1093 assigned cyberbono3 and blushi Jul 26, 2021

robert-zaremba approved these changes Jul 27, 2021

View reviewed changes

amaury1093 and others added 6 commits July 27, 2021 14:54

Update x/auth/client/cli/query.go

fade9f7

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

Update x/auth/client/cli/query.go

10f846e

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

Update x/auth/client/cli/query.go

2e9a636

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

Update x/auth/client/cli/query.go

4e19f3d

Co-authored-by: Robert Zaremba <robert@zaremba.ch>

Address review comments

91314fe

Merge branch 'master' into am/9741-tx-query

78b7526

amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Jul 27, 2021

mergify bot merged commit 7c19434 into master Jul 27, 2021

mergify bot deleted the am/9741-tx-query branch July 27, 2021 13:32

mergify bot mentioned this pull request Jul 27, 2021

feat: Query txs by signature and by address+seq (backport #9750) #9782

Merged

mergify bot mentioned this pull request Jul 27, 2021

feat: Query txs by signature and by address+seq (backport #9750) #9783

Merged

colin-axner mentioned this pull request Aug 5, 2021

Emit transaction fees in events #9857

Closed

4 tasks

fedekunze mentioned this pull request Nov 14, 2021

all: cherry pick olympus mons tharsis/cosmos-sdk#1

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Query txs by signature and by address+seq #9750

feat: Query txs by signature and by address+seq #9750

amaury1093 commented Jul 22, 2021

orijbot commented Jul 22, 2021

codecov bot commented Jul 22, 2021 •

edited

Loading

aaronc left a comment

odeke-em commented Jul 26, 2021

robert-zaremba left a comment

robert-zaremba Jul 27, 2021

amaury1093 Jul 27, 2021

robert-zaremba Jul 27, 2021

amaury1093 Jul 27, 2021

feat: Query txs by signature and by address+seq #9750

feat: Query txs by signature and by address+seq #9750

Conversation

amaury1093 commented Jul 22, 2021

Description

Author Checklist

Reviewers Checklist

orijbot commented Jul 22, 2021

codecov bot commented Jul 22, 2021 • edited Loading

Codecov Report

aaronc left a comment

Choose a reason for hiding this comment

odeke-em commented Jul 26, 2021

robert-zaremba left a comment

Choose a reason for hiding this comment

robert-zaremba Jul 27, 2021

Choose a reason for hiding this comment

amaury1093 Jul 27, 2021

Choose a reason for hiding this comment

robert-zaremba Jul 27, 2021

Choose a reason for hiding this comment

amaury1093 Jul 27, 2021

Choose a reason for hiding this comment

codecov bot commented Jul 22, 2021 •

edited

Loading