Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the contributing process #9814

Closed
4 tasks done
robert-zaremba opened this issue Jul 29, 2021 · 0 comments · Fixed by #10223
Closed
4 tasks done

Update the contributing process #9814

robert-zaremba opened this issue Jul 29, 2021 · 0 comments · Fixed by #10223
Assignees
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code)

Comments

@robert-zaremba
Copy link
Collaborator

Summary

We are redefining the Cosmos SDK contributing process to make it more efficient.

  • more code owners
  • more rigor in checklist

Ref: #9268

Goal

  • update the CONTRIBUTING.md file

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba added the T: Dev UX UX for SDK developers (i.e. how to call our code) label Jul 29, 2021
@robert-zaremba robert-zaremba added this to the v0.43 milestone Jul 29, 2021
@robert-zaremba robert-zaremba self-assigned this Jul 29, 2021
@robert-zaremba robert-zaremba modified the milestones: v0.43, Feature Backlog Jul 29, 2021
@github-actions github-actions bot added the stale label Sep 13, 2021
@mergify mergify bot closed this as completed in #10223 Oct 1, 2021
mergify bot pushed a commit that referenced this issue Oct 1, 2021
## Description

Closes: #9814

+ Updates the contributing page
+ Adds contributing guidelines 

NOTE:
+ This pr doesn't update the code owners section. We will still need to define it.

This is based on the discussion we had 2 months ago and recent chats.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant