feat!: ADR-040: Refactor App to use v2.MultiStore
#10174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-zaremba
requested review from
alexanderbez,
robert-zaremba,
aaronc and
AdityaSripal
7 tasks
roysc
changed the title
roysc
force-pushed
the
roysc/adr-040-refactor-multistore
branch
from
4f3a83d
to
75d96b1
Compare
roysc
force-pushed
the
roysc/adr-040-refactor-multistore
branch
from
75d96b1
to
4303bba
Compare
roysc
commented
Oct 21, 2021
There was a problem hiding this comment.
Comments from online review with @robert-zaremba and @alexanderbez
roysc
changed the title
19 tasks
roysc
force-pushed
the
roysc/adr-040-refactor-multistore
branch
from
4303bba
to
f71f755
Compare
roysc
force-pushed
the
roysc/adr-040-refactor-multistore
branch
from
f71f755
to
8efa2af
Compare
|
This pull request introduces 1 alert when merging 8efa2af into 8fc9f76 - view on LGTM.com new alerts:
|
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2021
## Description Part of: #10192 Introduces a new `RootStore` type in the `store/v2` package and an implementation, without yet replacing the `MultiStore` or refactoring its use within the SDK (which will happen in the follow up: #10174). Specified by [ADR-040](https://github.com/cosmos/cosmos-sdk/blob/1326fa2a7dfc3d83cf23dc1c1f33ff131152ad60/docs/architecture/adr-040-storage-and-smt-state-commitments.md). Fixes #10651 Fixes #10263 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [x] included comments for [documenting Go code](https://blog.golang.org/godoc) - [x] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
roysc
changed the title
v2.MultiStore
roysc
force-pushed
the
roysc/adr-040-refactor-multistore
branch
from
8efa2af
to
d94b249
Compare
github-actions
bot
added
C:Store
C:x/capability
C:x/distribution
simapp, baseapp and dependencies update db interface options refactor app.CloseStore() LoadLatestVersion => Init ...
* remove iterator read lock; doesn't play with orm tests, so just rely on the stated contract: no store writes while iterator open * use v2 store in orm tests * clean up app boilerplate * update NewCommitMultiStore() * fix NewUncachedContext
(cherry picked from commit f69c198) Co-authored-by: Roman <roman@osmosis.team>
github-actions
bot
removed
C:x/distribution
rm superfluous app.cms rename memdb imports [wip]substore prefix conflict
encode names with varint length to make them unambiguous
roysc
force-pushed
the
roysc/adr-040-refactor-multistore
branch
from
3afa273
to
1a9e194
Compare
Codecov Report
@@ Coverage Diff @@
## main #10174 +/- ##
==========================================
- Coverage 65.39% 65.24% -0.15%
==========================================
Files 693 688 -5
Lines 70965 72132 +1167
==========================================
+ Hits 46408 47066 +658
- Misses 21992 22325 +333
- Partials 2565 2741 +176
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+579
to
+583
| for v, _ := range vm.vmap { | ||
| if v > target { | ||
| delete(vm.vmap, v) | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+69
to
+71
| for skey, ls := range opts.listeners { | ||
| cms.AddListeners(skey, ls) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
| } | ||
|
|
||
| func (s *store1as2) GetVersion(ver int64) (v2.MultiStore, error) { | ||
| ret, err := s.CacheMultiStoreWithVersion(ver) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
Comment on lines
+43
to
+45
| for k := range backends { | ||
| keys = append(keys, string(k)) | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
Comment on lines
+53
to
+61
| for _, key := range keys { | ||
| typ, err := types.StoreKeyToType(key) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if err = par.RegisterSubstore(key, typ); err != nil { | ||
| return err | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
|
gonna close this for now. the work is still being reviewed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of: #10192
Closes #10804
Refactors the App state store and supporting code to use the new
store/v2.RootStoretype introduced by #10430.Specified by ADR-040.
Note:
Store behavior additions, changes (breakages?):
Closed to resolve DB transactionsCloseStore()to resolve its storeStoreTypePersistentfor substoresStoreTypeSMTfor SC-only smt.StoreAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change