feat: Add Tips middleware #10208
Merged
feat: Add Tips middleware #10208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit https://dashboard.github.orijtech.com?back=0&pr=10208&remote=false&repo=cosmos%2Fcosmos-sdk to see benchmark details. |
amaury1093
force-pushed
the
am/9912-tips-middleware
branch
2 times, most recently
from
e88a279 to
aaa956d
Compare
amaury1093
commented
Oct 1, 2021
alexanderbez
approved these changes
Oct 1, 2021
amaury1093
commented
Oct 5, 2021
|
Putting as draft for now, until we make a decision about tipper signing on ledger. |
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
Co-authored-by: Simon Warta <2603011+webmaster128@users.noreply.github.com>
amaury1093
force-pushed
the
am/9912-tips-middleware
branch
from
cef365a to
64123ed
Compare
amaury1093
commented
Oct 26, 2021
|
Pausing this (again) because of #10208 (comment) |
|
@AmauryM is it okay to close this for now? We can reopen when a decision has been made or its ready to continue, |
…912-tips-middleware
|
R4R again! |
tac0turtle
approved these changes
Nov 16, 2021
|
@marbar3778 Yeah agreed. I created #10426 some time ago, I think ideal docs should be a story around AuxTxBuilder, |
|
This has 2 approvals, but let's have someone from the TX working group also have a look - we'll assign someone during our sync today. |
aaronc
approved these changes
Nov 16, 2021
amaury1093
added
the
A:automerge
blewater
pushed a commit
to e-money/cosmos-sdk
that referenced
this pull request
Dec 8, 2021
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description R4R Closes: cosmos#9912 This PR introduces 1 new middleware: - `TipsMiddleware`: transfer tip from tipper to feePayer when relevant. It also makes sure in the DIRECT_AUX sign mode handler that the fee payer cannot use that sign mode. Depends on: - [x] cosmos#10028 - [x] cosmos#10268 - [x] cosmos#10322 - [x] cosmos#10346 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
R4R
Closes: #9912
This PR introduces 1 new middleware:
TipsMiddleware: transfer tip from tipper to feePayer when relevant.It also makes sure in the DIRECT_AUX sign mode handler that the fee payer cannot use that sign mode.
Depends on:
SIGN_MODE_AMINO_AUXhandler #10268Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change