fix: Charge gas even when there are no entries in gaskv

[likhita-809]

Description

Closes: #10127

Charge gas for seeks with empty ranges

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #10218 (bdba261) into master (15653f8) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head bdba261 differs from pull request most recent head 08b4b96. Consider uploading reports for the commit 08b4b96 to get more accurate results

@@            Coverage Diff             @@
##           master   #10218      +/-   ##
==========================================
+ Coverage   63.65%   63.67%   +0.01%     
==========================================
  Files         573      573              
  Lines       53762    53764       +2     
==========================================
+ Hits        34223    34234      +11     
+ Misses      17590    17583       -7     
+ Partials     1949     1947       -2     

Impacted Files	Coverage Δ
store/gaskv/store.go	100.00% <100.00%> (ø)
codec/yaml.go	53.84% <0.00%> (-8.66%)	⬇️
crypto/keys/internal/ecdsa/privkey.go	82.45% <0.00%> (-1.76%)	⬇️
client/context.go	56.88% <0.00%> (-0.26%)	⬇️
x/auth/migrations/legacytx/stdsign.go	78.31% <0.00%> (ø)
types/decimal.go	74.24% <0.00%> (+0.42%)	⬆️
x/staking/types/validator.go	60.49% <0.00%> (+0.70%)	⬆️
x/genutil/types/genesis_state.go	52.30% <0.00%> (+0.74%)	⬆️
types/address.go	68.69% <0.00%> (+1.82%)	⬆️
x/bank/types/params.go	96.00% <0.00%> (+4.75%)	⬆️

[robert-zaremba]

utACK

[amaury1093]

The failing test needs to be updated. Let's also make sure we have a test case where:

• the iterator points to an empty key/value
• yet the IterNextCostFlat is still charged

[ethanfrey]

Thanks for this.

I assume this will not be backported to the 0.44.x line? Or will it?

[likhita-809]

Thanks for this.

I assume this will not be backported to the 0.44.x line? Or will it?

I'm not sure about this.
@AmauryM can you make a comment on this ?

[amaury1093]

I assume this will not be backported to the 0.44.x line? Or will it?

I think backporting it makes sense

[ethanfrey]

Nice, I would be happy to see this.

Just want to comment that this is potentially state-breaking. (one one edge-case)
But you know best how to handle releases and numbering

[ethanfrey]

And while you are working on this, maybe you could look into this as well #10243

Another 3-10 line change that restrict abuse (and will have the same "state-breaking" gas impact as this PR, so maybe they can be back ported together)

Thank you

[amaury1093]

@Mergifyio backport release/v0.45.x

[mergify]

backport release/v0.45.x

✅ Backports have been created

• #10696 fix: Charge gas even when there are no entries in gaskv (backport #10218) has been created for branch release/v0.45.x