Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: #10178 reference authz from auth #10238

Merged
merged 8 commits into from
Sep 30, 2021
Merged

Conversation

brennhill
Copy link
Contributor

@brennhill brennhill commented Sep 27, 2021

Description

Closes: #10178

Adds the requested differential language between auth and authz modules. Resolves instances of future tense that were noticed.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • [NA] added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • [NA] followed the guidelines for building modules
  • [NA] included the necessary unit and integration tests
  • [NA] added a changelog entry to CHANGELOG.md
  • [NA] included comments for documenting Go code
  • updated the relevant documentation or specification
  • [NA] reviewed "Files changed" and left comments if necessary
  • [NA] confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@brennhill brennhill changed the title docs:#10178 reference authz from auth docs: #10178 reference authz from auth Sep 27, 2021
Copy link
Contributor

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brennhill thank you again for this awesome contribution to making the Cosmos SDK docs better

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small nit

x/auth/spec/01_concepts.md Outdated Show resolved Hide resolved
likhita-809 and others added 2 commits September 29, 2021 11:28
Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com>
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 29, 2021
@aaronc
Copy link
Member

aaronc commented Sep 29, 2021

I really do think we should move forward with #7615 in the next version of the auth module - basically rename auth to authn which follows the more standard convention of authn and authz for authentication and authorization respectively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/auth C:x/authz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs:(x/auth/spec/01_concepts.md) add comparative content to differentiate from authz module
7 participants