Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: x/bank/044 migrateDenomMetadata #10239

Merged
merged 8 commits into from
Sep 28, 2021
Merged

Conversation

robert-zaremba
Copy link
Collaborator

Description

Ref: #10060

Fixing x/bank/migrations/v44.migrateDenomMetadata - we could potentially put a wrong data in a new key if the old keys have variable length.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/bank/types/key.go Outdated Show resolved Hide resolved
@robert-zaremba robert-zaremba added A:automerge Automatically merge PR once all prerequisites pass. backport/0.44.x labels Sep 28, 2021
@robert-zaremba
Copy link
Collaborator Author

Adding a backport/0.44.x label.

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #10239 (74d8293) into master (9cea19d) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10239      +/-   ##
==========================================
+ Coverage   63.65%   63.67%   +0.01%     
==========================================
  Files         573      573              
  Lines       53796    53807      +11     
==========================================
+ Hits        34245    34260      +15     
+ Misses      17602    17598       -4     
  Partials     1949     1949              
Impacted Files Coverage Δ
x/bank/migrations/v044/keys.go 100.00% <100.00%> (ø)
x/bank/migrations/v044/store.go 75.00% <100.00%> (+1.31%) ⬆️
x/bank/types/key.go 100.00% <100.00%> (+17.64%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@robert-zaremba robert-zaremba merged commit 16a953c into master Sep 28, 2021
@robert-zaremba robert-zaremba deleted the robert/fix-migratedenom branch September 28, 2021 23:40
mergify bot pushed a commit that referenced this pull request Sep 28, 2021
* fix: x/bank/044 migrateDenomMetadata

* adding changelog entry

* comment update

* fix tests

(cherry picked from commit 16a953c)

# Conflicts:
#	CHANGELOG.md
#	x/bank/migrations/v044/keys.go
#	x/bank/migrations/v044/store.go
#	x/bank/migrations/v044/store_test.go
#	x/bank/types/key.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank T:Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants