Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rename v044 migrations to v045 #10260

Merged
merged 3 commits into from
Sep 29, 2021
Merged

chore: Rename v044 migrations to v045 #10260

merged 3 commits into from
Sep 29, 2021

Conversation

amaury1093
Copy link
Contributor

Description

In general, migrations in a vX package means that we're migration TO version X.

We added a new denom++address index in #9611, and this should go in 0.45. However, its migration went into package v044 because it was done before the v044 security release. To avoid confusion, I'm renaming that package to v045


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #10260 (e7458dc) into master (6f33514) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10260   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files         573      573           
  Lines       53816    53816           
=======================================
  Hits        34259    34259           
  Misses      17608    17608           
  Partials     1949     1949           
Impacted Files Coverage Δ
x/bank/keeper/migrations.go 33.33% <0.00%> (ø)
x/bank/migrations/v045/keys.go 100.00% <ø> (ø)
x/bank/migrations/v045/store.go 75.00% <ø> (ø)

@amaury1093 amaury1093 merged commit 1e2ef52 into master Sep 29, 2021
@amaury1093 amaury1093 deleted the am/rename-044-045 branch September 29, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants