Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add AuxTxBuilder #10455
feat: Add AuxTxBuilder #10455
Changes from 14 commits
fd811cc
e7c1f70
2c68763
dcfe5ae
d2f9ac4
fee39db
36ca5a7
4f73b55
72333b3
cbba311
a249828
eaf32d3
0a04112
9d18d47
b9f3cf3
0917b76
8a76a75
0acd018
3d95459
0d752ef
5327a79
77ab596
825b286
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add additional/deeper checks in these initial guards? A call to a single setter that calls
checkEmptyFields()
will makeb.body
,b.auxSignerData
, andb.auxSignerData.SignDoc
non-nil but that doesn't mean they are properly set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way I was thinking was to add some nil-guards here. Then, for actual validation, we call
b.auxSignerData.SignDoc.ValidateBasic()
andb.auxSignerData.ValidateBasic()
.