Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Add --fee-payer CLI flag, rename --fee-account to --fee-granter #10625

Merged
merged 8 commits into from
Dec 1, 2021
Merged

fix!: Add --fee-payer CLI flag, rename --fee-account to --fee-granter #10625

merged 8 commits into from
Dec 1, 2021

Conversation

askolesov
Copy link
Contributor

@askolesov askolesov commented Nov 26, 2021

Description

Closes: #10626

Changes:

  • Added --fee-payer CLI flag:
    • The flag is used to populate the corresponding context property.
    • Context in its turn is used to set fee-payer during transaction building.
  • --fee-account CLI flag is renamed to --fee-granter:
    • With the flag added it becomes unclear whether --fee-account stands for payer or granter.
    • Renaming to --fee-granter makes things more explicit.
    • This is CLI breaking change.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@askolesov askolesov changed the title [!fix] Pull fee-payer to context and cli fix!: Pull fee-payer to context and cli Nov 26, 2021
@github-actions github-actions bot removed the C:x/auth label Nov 26, 2021
@askolesov askolesov changed the title fix!: Pull fee-payer to context and cli fix!: Add --fee-payer CLI flag, rename --fee-account to --fee-granter Nov 26, 2021
@askolesov askolesov changed the title fix!: Add --fee-payer CLI flag, rename --fee-account to --fee-granter fix!: Add --fee-payer CLI flag, rename --fee-account to --fee-granter Nov 26, 2021
@askolesov askolesov changed the title fix!: Add --fee-payer CLI flag, rename --fee-account to --fee-granter fix!: Add --fee-payer CLI flag, rename --fee-account to --fee-granter Nov 26, 2021
@askolesov askolesov marked this pull request as ready for review November 26, 2021 17:37
@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Nov 28, 2021
@askolesov
Copy link
Contributor Author

Hi all,
Thanks for the review! What are the next steps to get it merged? There are two checks failing test-rosetta and upload-coverage-report. Can the PR be the reason?

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I always found fee-account to be super confusing

@amaury1093
Copy link
Contributor

Thanks for the review! What are the next steps to get it merged?

i have the Github message "This branch is out-of-date with the base branch". you'll need to merge master into your branch. A better way would be for us to have write access to your branch, we have a bot that does this.

@alexanderbez
Copy link
Contributor

Should this be backported to v0.44.x?

@amaury1093
Copy link
Contributor

amaury1093 commented Nov 30, 2021

There have been proponents and opponents of backporting CLI breaking changes. In doubt, I prefer to not backport. But if someone wants to backport + make it backwards-compatible, let's do that.

@alexanderbez
Copy link
Contributor

There have been proponents and opponents of backporting CLI breaking changes. In doubt, I prefer to not backport. But if someone wants to backport + make it backwards-compatible, let's do that.

Ahh I didn't realize this was CLI breaking, never mind then :-/

@askolesov askolesov closed this Nov 30, 2021
@askolesov askolesov deleted the cheqd_fee-payer-cli branch November 30, 2021 17:33
@askolesov askolesov restored the cheqd_fee-payer-cli branch November 30, 2021 17:33
@askolesov
Copy link
Contributor Author

Wait, what did happen? I didn't close this

@askolesov askolesov reopened this Dec 1, 2021
@askolesov
Copy link
Contributor Author

Master branch updates faster than checks passes so it's hard to keep it up to date...

@tac0turtle
Copy link
Member

when editing your pr there should be a checkbox to allow maintainers to modify the PR, this allows us to update to master and avoid pinging you

@mergify mergify bot merged commit 001be0f into cosmos:master Dec 1, 2021
blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
…anter` (cosmos#10625)

<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: cosmos#10626

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

Changes:
- Added `--fee-payer` CLI flag:
  - The flag is used to populate the corresponding `context` property.
  - Context in its turn is used to set `fee-payer` during transaction building.
- `--fee-account` CLI flag is renamed to `--fee-granter`:
  - With the  flag added it becomes unclear whether `--fee-account` stands for `payer` or `granter`.
  - Renaming to `--fee-granter` makes things more explicit.
  - This is CLI breaking change.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] provided a link to the relevant issue or specification
- [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [x] added a changelog entry to `CHANGELOG.md`
- [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [x] updated the relevant documentation or specification
- [x] reviewed "Files changed" and left comments if necessary
- [x] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
@amaury1093 amaury1093 mentioned this pull request May 23, 2022
72 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/feegrant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't set fee-payer both in context and cli.
4 participants