Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: edit validator bug from the cli #10684

Merged
merged 9 commits into from
Dec 8, 2021
Merged

Conversation

aleem1314
Copy link
Contributor

Description

Closes: #10660


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aleem1314 aleem1314 marked this pull request as ready for review December 7, 2021 15:20
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, couple of nits!

CHANGELOG.md Outdated Show resolved Hide resolved
x/staking/client/testutil/suite.go Outdated Show resolved Hide resolved
atheeshp and others added 3 commits December 8, 2021 15:13
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
Co-authored-by: atheeshp <59333759+atheeshp@users.noreply.github.com>
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Dec 8, 2021
@mergify mergify bot merged commit d794b97 into master Dec 8, 2021
@mergify mergify bot deleted the aleem/10660-edit-validator branch December 8, 2021 11:08
blewater pushed a commit to e-money/cosmos-sdk that referenced this pull request Dec 8, 2021
<!--
The default pull request template is for types feat, fix, or refactor.
For other templates, add one of the following parameters to the url:
- template=docs.md
- template=other.md
-->

## Description

Closes: cosmos#10660 

<!-- Add a description of the changes that this PR introduces and the files that
are the most critical to review. -->

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this actually fix anything? You just renamed the flag.

@atheeshp
Copy link
Contributor

atheeshp commented Dec 10, 2021

How does this actually fix anything? You just renamed the flag.

If we are not setting the --moniker flag while editing the validator details config.toml's moniker value is being set to --moniker flag.

@alexanderbez
Copy link
Contributor

Interesting. What's the path for that behavior?

@likhita-809 likhita-809 added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Jun 21, 2022
@likhita-809
Copy link
Contributor

@Mergifyio backport 0.45.x

@likhita-809
Copy link
Contributor

@Mergifyio backport 0.46.x

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

backport 0.45.x

❌ No backport have been created

  • Backport to branch 0.45.x failed: Branch not found

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

backport 0.46.x

❌ No backport have been created

  • Backport to branch 0.46.x failed: Branch not found

@likhita-809
Copy link
Contributor

@Mergifyio backport release/v0.45.x

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

backport release/v0.45.x

❌ No backport have been created

  • Backport to branch release/v0.45.x failed: Git reported the following error:
fatal: couldn't find remote ref master

@likhita-809
Copy link
Contributor

@Mergifyio backport release/v0.46.x

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2022

backport release/v0.46.x

❌ No backport have been created

  • Backport to branch release/v0.46.x failed: Git reported the following error:
fatal: couldn't find remote ref master

@likhita-809 likhita-809 mentioned this pull request Jun 21, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edit validator bug from the command line
6 participants