Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update rosetta-sdk-go and rosetta-cli #10707

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

fkneeland-figure
Copy link
Contributor

@fkneeland-figure fkneeland-figure commented Dec 8, 2021

Description

A fix to rosetta was recently merged and tagged for an issue with rosetta causing tests to fail on chains with coins minted post genesis. We should consume this fix: coinbase/mesh-sdk-go#358

Closes: #10706


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:Rosetta Issues and PR related to Rosetta label Dec 8, 2021
@fkneeland-figure fkneeland-figure changed the title Bump: Update rosetta-sdk-go and rosetta-cli feat: Update rosetta-sdk-go and rosetta-cli Dec 8, 2021
@fkneeland-figure fkneeland-figure marked this pull request as ready for review December 8, 2021 23:30
@fkneeland-figure
Copy link
Contributor Author

This is ready for review

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Dec 9, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but test-rosetta seems to pass so i guess i'm fine

@mergify mergify bot merged commit 94def69 into cosmos:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:Rosetta Issues and PR related to Rosetta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump: Rosetta-sdk and Rosetta-cli deps
3 participants