Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use full gas on overflow #10897

Merged
merged 5 commits into from
Jan 7, 2022
Merged

fix: use full gas on overflow #10897

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dce994a
fix: use full gas on overflow
robert-zaremba Jan 6, 2022
682dea1
cosmetic changes
robert-zaremba Jan 7, 2022
a3d2771
Merge branch 'master' into robert/gas-consumed
robert-zaremba Jan 7, 2022
838b318
add changelog
robert-zaremba Jan 7, 2022
45f483c
Merge branch 'master' into robert/gas-consumed
robert-zaremba Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion store/types/gas.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,9 @@ func addUint64Overflow(a, b uint64) (uint64, bool) {
// ConsumeGas adds the given amount of gas to the gas consumed and panics if it overflows the limit or out of gas.
func (g *basicGasMeter) ConsumeGas(amount Gas, descriptor string) {
var overflow bool
// TODO: Should we set the consumed field after overflow checking?
g.consumed, overflow = addUint64Overflow(g.consumed, amount)
if overflow {
g.consumed = math.MaxUint64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's good catch, so when overflow, it'll consume less from block gas meter?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, though this is super unlikely - requires a weird app config.

panic(ErrorGasOverflow{descriptor})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't cancel the gas consumption, but cancels other execution. So we will charge a max possible amount of gas.

}

Expand Down