-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: prune everything #11177
refactor: prune everything #11177
Conversation
I don't think this solves the issue. If I understand it correctly you are assuming it takes less time to snapshot than it does to proceed two blocks. I think in some cases this would work but for chains with large amounts of current state you would still get data base corruption. If this is the case I would suggest using snapshot-interval the same way we had keep-every, except after the snapshot is saved we prune that height. |
@marbar3778 this PR has nothing to do with snapshotting. It has to do with fixing the off by on error, i.e. the |
Yes I know. But only keeping the last two blocks will only fix some on the issues is what I'm saying. If the snapshot takes longer than two blocks the app will try to prune a version that has an active reader on it. |
I see. I mean it would be ideal to not have to conflate the two things. The issue you state is currently also an issue. What do you propose exactly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@marbar3778 @AmauryM wdyt about backporting this? There technically aren't any API breaking changes. The only thing that would happen now is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! Im in favor of backporting this
(cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go
(cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go
(cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/config.go # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go
* refactor: prune everything (#11177) (cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go * updates * updates * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
* refactor: prune everything (cosmos#11177) (cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go * updates * updates * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
* refactor: prune everything (cosmos#11177) (cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go * updates * updates * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
* refactor: prune everything (cosmos#11177) (cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go * updates * updates * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
* refactor: prune everything (cosmos#11177) (cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go * updates * updates * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
* refactor: prune everything (cosmos#11177) (cherry picked from commit 75bcf47) # Conflicts: # CHANGELOG.md # server/config/toml.go # server/start.go # store/rootmulti/store.go # store/types/pruning.go # store/v2/multi/store_test.go * updates * updates * updates * updates * updates Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com>
Description
Closes: #10352
everything
pruning setting to keep the previous state in addition to the current state.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change