Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(errors): support grpc codes #11274

Merged
merged 1 commit into from
Feb 25, 2022
Merged

feat(errors): support grpc codes #11274

merged 1 commit into from
Feb 25, 2022

Conversation

aaronc
Copy link
Member

@aaronc aaronc commented Feb 25, 2022

Description

Follow-up to #11113 (review).

This PR also makes New an alias of Register as some packages are using New as if it were Register but are not actually registering their error codes.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@aaronc aaronc marked this pull request as ready for review February 25, 2022 18:05
@aaronc aaronc requested a review from alexanderbez as a code owner February 25, 2022 18:05
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #11274 (ac2a54c) into master (57b4613) will decrease coverage by 0.06%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11274      +/-   ##
==========================================
- Coverage   66.11%   66.05%   -0.07%     
==========================================
  Files         706      665      -41     
  Lines       72523    68595    -3928     
==========================================
- Hits        47951    45309    -2642     
+ Misses      21585    20645     -940     
+ Partials     2987     2641     -346     
Impacted Files Coverage Δ
errors/errors.go 83.78% <85.71%> (ø)
orm/encoding/ormkv/key_codec.go
orm/model/ormtable/primary_key.go
orm/encoding/ormkv/entry.go
orm/encoding/ormkv/primary_key.go
orm/model/ormtable/singleton.go
orm/model/ormtable/paginate.go
db/version_manager.go
orm/model/ormdb/json.go
db/rocksdb/iterator.go
... and 42 more

Copy link
Contributor

@fdymylja fdymylja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

I'd mark the change in New as breaking in the changelog, since it is a behavioural change.

@aaronc
Copy link
Member Author

aaronc commented Feb 25, 2022

Finally!

I'd mark the change in New as breaking in the changelog, since it is a behavioural change.

I'll update the CHANGELOG on master after I tag errors and update the main go.mod. Right now the current types/errors isn't broken until the go.mod gets updated. (This module is still beta)

@aaronc aaronc mentioned this pull request Feb 25, 2022
29 tasks
Copy link
Contributor

@technicallyty technicallyty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aaronc aaronc added A:automerge Automatically merge PR once all prerequisites pass. C:errors labels Feb 25, 2022
@mergify mergify bot merged commit 9a87557 into master Feb 25, 2022
@mergify mergify bot deleted the aaronc/errors-grpc-status branch February 25, 2022 20:58
mergify bot pushed a commit that referenced this pull request Mar 13, 2022
## Description

Follow-up to #11274 



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
mergify bot pushed a commit that referenced this pull request Mar 16, 2022
## Description

Follows up on #11274 to properly support wrapped errors.



---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants