-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add transaction tips documentation #11426
Conversation
b842662
to
dff3742
Compare
dff3742
to
cbb1472
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally like the approach Osmosis is taking, where you accept governance-approved fees (via an accept list) and send those fees to a dedicated module account, where you can then swap for native asset(s) later to be distributed to stakeholders.
cc @ValarDragon
But this approach is also interesting and useful too :)
Is there a plan adding this to the SDK? It would be nice to have a pros/cons of the 2 different approaches for SDK users. Maybe Emeris can argue why tips suit their use case better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting read :)
Yeah its a two part thing. One is ante-handler middleware, the other is the actual swapping. The former I can add easily. The other requires oracle over IBC, probably via osmosis. Or maybe even using IA to execute a swap. |
Description
Closes: #10426
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change