Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(staking): add cancel-unbond delegations spec #11473

Merged
merged 14 commits into from
Apr 7, 2022
Merged

docs(staking): add cancel-unbond delegations spec #11473

merged 14 commits into from
Apr 7, 2022

Conversation

gsk967
Copy link
Contributor

@gsk967 gsk967 commented Mar 28, 2022

Description

Closes: #XXXX

related to #10885


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@gsk967 gsk967 marked this pull request as ready for review March 30, 2022 06:24
@amaury1093
Copy link
Contributor

I think this should wait for #10885 first

@gsk967 gsk967 changed the title docs(staking): add cancel-unbond delegations sepc docs(staking): add cancel-unbond delegations spec Apr 5, 2022
@tac0turtle
Copy link
Member

@AmauryM I think this is ready now?

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just some language changes

x/staking/spec/02_state_transitions.md Outdated Show resolved Hide resolved
x/staking/spec/03_messages.md Outdated Show resolved Hide resolved
x/staking/spec/02_state_transitions.md Outdated Show resolved Hide resolved
x/staking/spec/02_state_transitions.md Outdated Show resolved Hide resolved
x/staking/spec/03_messages.md Outdated Show resolved Hide resolved
x/staking/spec/03_messages.md Outdated Show resolved Hide resolved
x/staking/spec/03_messages.md Outdated Show resolved Hide resolved
x/staking/spec/09_client.md Outdated Show resolved Hide resolved
Copy link
Contributor

@atheeshp atheeshp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x/staking/spec/02_state_transitions.md Outdated Show resolved Hide resolved
x/staking/spec/03_messages.md Outdated Show resolved Hide resolved
x/staking/spec/02_state_transitions.md Outdated Show resolved Hide resolved
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 7, 2022
@mergify mergify bot merged commit feb9d93 into cosmos:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants