Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic in authz #11512

Merged
merged 8 commits into from
Apr 4, 2022
Merged

fix: panic in authz #11512

merged 8 commits into from
Apr 4, 2022

Conversation

atheeshp
Copy link
Contributor

Description

Closes: #11478


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp changed the title fix: handle panic in authz fix: get rid of a panic in authz Mar 31, 2022
@atheeshp atheeshp changed the title fix: get rid of a panic in authz fix: panic in authz Mar 31, 2022
@atheeshp atheeshp marked this pull request as ready for review March 31, 2022 20:39
@amaury1093
Copy link
Contributor

Let's add a changelog entry

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 4, 2022
@tac0turtle
Copy link
Member

seems this is causing sims to fail

@atheeshp atheeshp removed the A:automerge Automatically merge PR once all prerequisites pass. label Apr 4, 2022
@atheeshp
Copy link
Contributor Author

atheeshp commented Apr 4, 2022

seems this is causing sims to fail

yeah, but can't reproduce in the local and they are passing in the last commit too. I've checked the previous commits too, there is no failure of checks which are failing in the last 2 commits. And also the failed tests are related to the group module not related to the current changes.

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 4, 2022
@mergify mergify bot merged commit 9f6f9f5 into master Apr 4, 2022
@mergify mergify bot deleted the ap/handle_panic branch April 4, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Authorization logic of staking module: panic when handling amounts greater than authorized
4 participants