Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove migrations 0.42 and below #11556

Merged
merged 12 commits into from
Apr 7, 2022
Merged

chore: remove migrations 0.42 and below #11556

merged 12 commits into from
Apr 7, 2022

Conversation

tac0turtle
Copy link
Member

Description

Removes migrations from 0.42 and below.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle mentioned this pull request Apr 6, 2022
Closed
19 tasks
@tac0turtle tac0turtle marked this pull request as ready for review April 6, 2022 10:19
julienrbrt
julienrbrt reviewed Apr 6, 2022
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some v043 migrations import the v040 migration package making the build fail:
e.g. https://github.com/cosmos/cosmos-sdk/blob/marbar/remove_legacy/x/staking/migrations/v043/store.go#L10

I see that you are fast 😆

@github-actions github-actions bot added the C:CLI label Apr 6, 2022
julienrbrt
julienrbrt approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

robert-zaremba
robert-zaremba approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I 've already created PR for that 2 months ago... I think we had to just remove few commits from it.

@tac0turtle
Copy link
Member Author

I 've already created PR for that 2 months ago... I think we had to just remove few commits from it.

yea decided to take your work and push it over the finish line

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 7, 2022
@amaury1093 amaury1093 removed the A:automerge Automatically merge PR once all prerequisites pass. label Apr 7, 2022
@amaury1093
Copy link
Contributor

Can we add a changelog, it's technically API breaking

amaury1093
amaury1093 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, proposed small package naming change to be more explicit

amaury1093
amaury1093 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 7, 2022
@mergify mergify bot merged commit fdd3d07 into master Apr 7, 2022
@mergify mergify bot deleted the marbar/remove_legacy branch April 7, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrbrt julienrbrt julienrbrt approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@robert-zaremba robert-zaremba robert-zaremba approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees

@blushi blushi

Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/auth C:x/bank C:x/crisis C:x/distribution distribution module related C:x/evidence C:x/genutil genutil module issues C:x/gov C:x/mint C:x/params C:x/slashing C:x/staking C:x/upgrade
Projects
No open projects
Cosmos SDK: Core Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tac0turtle @amaury1093 @robert-zaremba @julienrbrt @blushi