-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: register x/authz module specific errors #11670
Merged
alexanderbez
merged 10 commits into
master
from
julien/11577-xauthz-module-specific-errors-should-be-registered
Apr 19, 2022
Merged
refactor: register x/authz module specific errors #11670
alexanderbez
merged 10 commits into
master
from
julien/11577-xauthz-module-specific-errors-should-be-registered
Apr 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-should-be-registered
alexanderbez
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀 🚀
…-should-be-registered
atheeshp
reviewed
Apr 19, 2022
@julienrbrt let's get the CI errors resolved (https://github.com/cosmos/cosmos-sdk/runs/6078819769?check_suite_focus=true) and we can merge this 🙌 |
…-should-be-registered
Codecov Report
@@ Coverage Diff @@
## master #11670 +/- ##
==========================================
+ Coverage 65.84% 65.90% +0.06%
==========================================
Files 667 671 +4
Lines 70374 70643 +269
==========================================
+ Hits 46336 46559 +223
- Misses 21347 21380 +33
- Partials 2691 2704 +13
|
alexanderbez
deleted the
julien/11577-xauthz-module-specific-errors-should-be-registered
branch
April 19, 2022 19:08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11577
Implement suggestion from the issue above.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change