-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Bug reading password from a buffer when reader returns EOF #11796
fix: Bug reading password from a buffer when reader returns EOF #11796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@alexanderbez thanks for the review. I've applied your suggestions :) |
@Vizualni can you enable access for pushing/updating on your forks? That way, you don't have to keep manually updating. |
Hey @alexanderbez. Could you explain to me what exactly I need to do here? I don't see any restriction which tells me that you shouldn't be able to do this. Also, there is test-race(00) that fails. Is this something that's known or was it introduced with this PR? |
(cherry picked from commit e44a4a9)
(cherry picked from commit e44a4a9)
I don't remember the exact setting you have to change. @marbar3778 do you recall? |
Description
When providing a password from a io.Reader it returns io.EOF when it's done reading. Function
readLineFromBuf
then returns the error and discards the password read.This fixes it and there are tests verifying the behaviour.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change