Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: invalid return value from keeper GetLastCompleteUpgrade - breaking change version #11800

Merged

Conversation

daeMOn63
Copy link
Contributor

@daeMOn63 daeMOn63 commented Apr 27, 2022

Description

This change indexing the "Done upgrades" from the store, from their name only to height+name, in order to ensure correct ordering.

This intends to provide a better solution to #11707 than #11705 but requires a store migration.

Closes: #11707


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

This change indexing the "Done upgrades" from the store, from their name only to height+name, in order to ensure correct ordering.
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

x/upgrade/keeper/keeper.go Outdated Show resolved Hide resolved
x/upgrade/keeper/keeper.go Outdated Show resolved Hide resolved
x/upgrade/module.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

x/upgrade/keeper/keeper.go Show resolved Hide resolved
x/upgrade/keeper/keeper.go Outdated Show resolved Hide resolved
@robert-zaremba
Copy link
Collaborator

anyone against backporting it to 0.46?

@daeMOn63
Copy link
Contributor Author

anyone against backporting it to 0.46?

is 0.45 an option?

@alexanderbez
Copy link
Contributor

anyone against backporting it to 0.46?

is 0.45 an option?

No this is state breaking. Only reason 0.46 is an option is because we haven't officially released it yet.

@robert-zaremba, yes, let's backport to 0.46 please.

@ValarDragon
Copy link
Contributor

Yes, lets please make this v0.46 blocking

Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to ignore my two comment updates

@alexanderbez alexanderbez requested a review from a team as a code owner April 30, 2022 18:48
alexanderbez and others added 2 commits April 30, 2022 14:48
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
@alexanderbez alexanderbez added the backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release label Apr 30, 2022
@alexanderbez alexanderbez merged commit b6c3756 into cosmos:main May 2, 2022
mergify bot pushed a commit that referenced this pull request May 2, 2022
alexanderbez pushed a commit that referenced this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:x/upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: x/upgrade keeper GetLastCompleteUpgrade returns wrong upgrade name
4 participants