feat!: support custom r/w gRPC options #11889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
the
C: gRPC
alexanderbez
changed the title
alexanderbez
changed the title
|
Can this be backported? |
Yes! I think it should...as long as you don't mind the slight change to the |
|
Going to merge and we can decide to backport to what/if later. |
4 tasks
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
May 25, 2023
zemyblue
added a commit
to Finschia/finschia-sdk
that referenced
this pull request
May 27, 2023
* feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889) * chore: add simple unittest for app config * chore: update changelog
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
May 27, 2023
* feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889) * chore: add simple unittest for app config * chore: update changelog (cherry picked from commit 13ae1f6)
zemyblue
added a commit
to Finschia/finschia-sdk
that referenced
this pull request
May 30, 2023
* feat: support custom r/w gRPC options (#1017) * feat: support custom r/w gRPC options (backport cosmos/cosmos-sdk#11889) * chore: add simple unittest for app config * chore: update changelog (cherry picked from commit 13ae1f6) * chore: update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide the ability for operators to set custom r/w gRPC options in
app.toml. Note, operators are not required to update theirapp.tomlas a safe guard is also added when values are 0 to use default values.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change