chore: Audit x/staking and add "Since" proto comments #11920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58 tasks
alexanderbez
approved these changes
May 10, 2022
alexanderbez
added
the
A:automerge
amaury1093
commented
May 10, 2022
| @@ -35,6 +35,8 @@ service Msg { | |||
|
|
|||
| // CancelUnbondingDelegation defines a method for performing canceling the unbonding delegation | |||
| // and delegate back to previous validator. | |||
| // | |||
| // Since: cosmos-sdk 0.46 | |||
There was a problem hiding this comment.
Any ideas how we can enforce this better, that we don't forget then in normal PRs?
They are becoming important with the new app wiring.
Codecov Report
@@ Coverage Diff @@
## main #11920 +/- ##
=======================================
Coverage 66.03% 66.03%
=======================================
Files 675 675
Lines 71282 71282
=======================================
Hits 47072 47072
- Misses 21530 21531 +1
+ Partials 2680 2679 -1
|
amaury1093
commented
May 10, 2022
| @@ -23,7 +23,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| consensusVersion uint64 = 4 | |||
| consensusVersion uint64 = 3 | |||
There was a problem hiding this comment.
Explanation: we were at 2 in v0.45
cosmos-sdk/x/staking/module.go
Line 164 in 8bbeba5
No need to bump 2 versions at once
alexanderbez
removed
the
A:automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #11362
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change